1988516 - Update PDF.js to new version 3432c1933e251e4280a029a1308578b422f36b99 from 2025-09-15 06:27:17

Status: RESOLVED DUPLICATE of bug 1988699

(Firefox :: PDF Viewer, enhancement)

Description

[Update Bot]

This update covers 43 commits. Here are the overall diff statistics, and then the commit information.

---

toolkit/components/pdfjs/PdfJsDefaultPrefs.js | 1 +
toolkit/components/pdfjs/content/build/pdf.mjs | 1975 ++++++---
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 21 +-
toolkit/components/pdfjs/content/web/debugger.mjs | 163 +-
toolkit/components/pdfjs/content/web/images/comment-editButton.svg | 12 +-
toolkit/components/pdfjs/content/web/images/comment-popup-editButton.svg | 5 +
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 21 +
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 1095 ++++-
toolkit/components/pdfjs/content/web/viewer.css | 743 ++-
toolkit/components/pdfjs/content/web/viewer.html | 45 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 1134 ++++-
toolkit/components/pdfjs/moz.yaml | 4 +-
toolkit/locales/en-US/toolkit/pdfviewer/viewer.ftl | 53 +-
14 files changed, 3781 insertions(+), 1495 deletions(-)

---

b660b721f9675c942dee54694a0b227177cb3c99 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/b660b721f9675c942dee54694a0b227177cb3c99
Authored: 2025-09-08 18:27:12 +0200
Committed: 2025-09-15 08:24:26 +0200

[Editor] Add a new popup for comments (bug 1987425)

And:

• improve the editing dialog in removing menu;
• position correctly the popup on the left/right depending on the direction value.

Files Added:

• web/images/comment-popup-editButton.svg

Files Modified:

• extensions/chromium/preferences_schema.json
• l10n/en-US/viewer.ftl
• src/display/editor/annotation_editor_layer.js
• src/display/editor/comment.js
• src/display/editor/draw.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/toolbar.js
• src/display/editor/tools.js
• web/annotation_editor_layer_builder.css
• web/app.js
• web/app_options.js
• web/comment_manager.css
• web/comment_manager.js
• web/pdf_viewer.js
• web/viewer.html
• web/viewer.js

---

2f53e50074b11a3843d5b2b87b4c6981aa88012a by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/2f53e50074b11a3843d5b2b87b4c6981aa88012a
Authored: 2025-09-14 18:46:44 +0200
Committed: 2025-09-14 19:23:35 +0200

Update translations to the most recent versions

Files Modified:

• l10n/ca/viewer.ftl
• l10n/es-ES/viewer.ftl
• l10n/eu/viewer.ftl
• l10n/id/viewer.ftl
• l10n/is/viewer.ftl
• l10n/kk/viewer.ftl
• l10n/th/viewer.ftl

---

637599dc23c6a1bf2ed7e781c5d09ae713f6127e by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/637599dc23c6a1bf2ed7e781c5d09ae713f6127e
Authored: 2025-09-14 18:45:21 +0200
Committed: 2025-09-14 19:23:34 +0200

Upgrade eslint-plugin-unicorn to version 61.0.2

This is a major version bump, but the changelog at
https://github.com/sindresorhus/eslint-plugin-unicorn/releases/tag/v61.0.0
doesn't indicate any breaking changes that should impact us.

Files Modified:

• package-lock.json
• package.json

---

a730cba414664032b0ccc77d33e3456922740fd8 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/a730cba414664032b0ccc77d33e3456922740fd8
Authored: 2025-09-14 18:44:31 +0200
Committed: 2025-09-14 19:23:34 +0200

Update dependencies to the most recent versions

Files Modified:

• gulpfile.mjs
• package-lock.json
• package.json

---

b6d772d71dcdf9620fd398f7a5a9bc7446346e6d by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/b6d772d71dcdf9620fd398f7a5a9bc7446346e6d
Authored: 2025-09-14 14:46:00 +0200
Committed: 2025-09-14 18:52:16 +0200

Consider a ttf font with both Symbolic and Nonsymbolic flags set with a Differences array in the encoding dict as non-symbolic

It fixes #20232.

Files Added:

• test/pdfs/issue20232.pdf

Files Modified:

• src/core/evaluator.js
• test/pdfs/.gitignore
• test/test_manifest.json

---

ffeaa9111ae7802a1bcdb97acf346dcdbd875b40 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/ffeaa9111ae7802a1bcdb97acf346dcdbd875b40
Authored: 2025-09-07 19:25:06 +0200
Committed: 2025-09-14 18:30:17 +0200

Replace manual returns with pending in the integration tests

This allows Jasmine to track skipped tests and makes it easier to
discover them using e.g. grep.

Files Modified:

• test/integration/highlight_editor_spec.mjs
• test/integration/ink_editor_spec.mjs
• test/integration/viewer_spec.mjs

---

634bef5fb4be1ee856c598b51eabe95129db9804 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/634bef5fb4be1ee856c598b51eabe95129db9804
Authored: 2025-09-13 15:44:56 +0200
Committed: 2025-09-13 15:45:00 +0200

Use a dichotomy to find a color with a good contrast ratio

It helps to reduce the number of iterations so it makes the algorithm
slightly faster in general.

Files Modified:

• src/display/display_utils.js
• test/unit/display_utils_spec.js

---

5de14aa429f65c6e15d299b9d5367c371095975d by Nicolò Ribaudo <[e-mail]>

https://github.com/mozilla/pdf.js/+/5de14aa429f65c6e15d299b9d5367c371095975d
Authored: 2025-09-09 14:54:59 +0200
Committed: 2025-09-12 15:02:24 +0200

Only record bboxes when needed

Before this patch, when enableOptimizedPartialRendering
is enabled we would record the bounding boxes of the
various operations on the first render.

This patches change it to happen on the first render that we
know will also need a detail view, so that the performance
cost is not paid for the case when the detail view is not used.

Files Modified:

• web/pdf_page_detail_view.js
• web/pdf_page_view.js

---

42b4d97115c2b705fc5541ce85a161d26a0fb6ef by Nicolò Ribaudo <[e-mail]>

https://github.com/mozilla/pdf.js/+/42b4d97115c2b705fc5541ce85a161d26a0fb6ef
Authored: 2025-09-12 15:01:41 +0200
Committed: 2025-09-12 15:01:41 +0200

Fix JSDoc description in src/display/api.js

Files Modified:

• src/display/api.js

---

7f85c00ee6faac9118e13e630c9a6b754217f90f by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/7f85c00ee6faac9118e13e630c9a6b754217f90f
Authored: 2025-09-07 22:00:30 +0200
Committed: 2025-09-11 21:29:28 +0200

Make sure that a good constrast ratio is respected when darkening/lightening a color

Files Modified:

• src/display/annotation_layer.js
• src/display/display_utils.js
• src/display/editor/editor.js
• src/pdf.js
• test/unit/display_utils_spec.js
• test/unit/pdf_spec.js
• web/comment_manager.css
• web/comment_manager.js
• web/pdfjs.js
• web/viewer.html

---

4c7bbd0fef7a94581eaca53dd665cd371a988671 by Nicolò Ribaudo <[e-mail]>

https://github.com/mozilla/pdf.js/+/4c7bbd0fef7a94581eaca53dd665cd371a988671
Authored: 2025-09-09 13:43:01 +0200
Committed: 2025-09-10 16:52:57 +0200

Reduce background canvas resolution

The size of the canvas has significant impact on the rendering
performance. If we are going to render a high-res detail
view on top of the full-page canvas, we can further
reduce the full-page canvas resolution to improve
rendering time without affecting the resolution seen by
the user.

Users will se the lower resolution when quickly scrolling around the
page, but it will then be replaced with the high-res
detail view.

Files Modified:

• test/integration/viewer_spec.mjs
• web/pdf_page_view.js

---

593ceadc93c6bf46b90438f26aa249b593ef8b6d by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/593ceadc93c6bf46b90438f26aa249b593ef8b6d
Authored: 2025-09-10 11:04:41 +0200
Committed: 2025-09-10 11:04:47 +0200

[Editor] Don't throw when switching to editing mode before an annotation editor layer is rendered

It can happen with a pdf having a large text layer.
Instead of waiting for the first rendered page to enable the buttons we wait for
a rendered annotation editor layer.

Files Modified:

• web/pdf_viewer.js

---

0fc8986dc662dc223c6f22ece6961a194ccfbdeb by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/0fc8986dc662dc223c6f22ece6961a194ccfbdeb
Authored: 2025-09-10 10:23:20 +0200
Committed: 2025-09-10 10:23:29 +0200

[Editor] Cleanup the pages not being fully rendered before switching to editing mode

In order to see the issue this patch is fixing:

• open a pdf with some highlights and a comment on page 1, at page 7
• open the comment sidebar
• click on the comment on page 1

Opening at page 7 lets a not fully rendered page which means that when jumping to it
with the sidebar, we re-use what we've instead of redrawing it.

Files Modified:

• web/pdf_page_view.js
• web/pdf_viewer.js

---

e1bdc34b4afa83b1f9e1427f8212c5a5dcbb4cd5 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/e1bdc34b4afa83b1f9e1427f8212c5a5dcbb4cd5
Authored: 2025-09-09 13:10:49 +0200
Committed: 2025-09-09 13:10:49 +0200

Add an option in scrollIntoView and goToXY in order to be able to center vertically or horizontally the point XY in the viewer container

Files Added:

• test/pdfs/tracemonkey_annotation_on_page_8.pdf

Files Modified:

• test/integration/viewer_spec.mjs
• test/pdfs/.gitignore
• web/pdf_link_service.js
• web/pdf_viewer.js

---

e4ea2e0c790a8f3d238a80b11d56cd7c0258e6a1 by Nicolò Ribaudo <[e-mail]>

https://github.com/mozilla/pdf.js/+/e4ea2e0c790a8f3d238a80b11d56cd7c0258e6a1
Authored: 2025-08-27 11:04:34 +0200
Committed: 2025-09-09 10:24:48 +0200

Store ops bboxes in a linear Uint8Array

This PR changes the way we store bounding boxes so that they use less
memory and can be more easily shared across threads in the future.

Instead of storing the bounding box and list of dependencies for each
operation that renders something, we now only store the bounding box
of every operation and no dependencies list. The bounding box of
each operation covers the bounding box of all the operations affected
by it that render something. For example, the bounding box of a
setFont operation will be the bounding box of all the showText
operations that use that font.

This affects the debugging experience in pdfBug, since now the bounding
box of an operation may be larger than what it renders itself. To help
with this, now when hovering on an operation we also highlight (in red)
all its dependents. We highlight with white stripes operations that do
not affect any part of the page (i.e. with an empty bbox).

To save memory, we now save bounding box x/y coordinates as uint8
rather than float64. This effectively gives us a 256x256 uniform grid
that covers the page, which is high enough resolution for the usecase.

Files Modified:

• src/display/api.js
• src/display/canvas.js
• src/display/canvas_dependency_tracker.js
• src/display/pattern_helper.js
• test/driver.js
• test/test_manifest.json
• web/base_pdf_page_view.js
• web/debugger.mjs
• web/pdf_page_detail_view.js
• web/pdf_page_view.js

---

512c30b1f68e6878fdf420d04784b37f54f7b448 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/512c30b1f68e6878fdf420d04784b37f54f7b448
Authored: 2025-09-07 19:29:03 +0200
Committed: 2025-09-08 20:48:24 +0200

Unskip the must check that date entered by the user is consistent scripting integration test for Firefox

Bug 1978027 has been fixed upstream 10 days ago, so this integration
test can be enabled for Firefox too now that it passed with recent
Nightly versions.

Files Modified:

• test/integration/scripting_spec.mjs

---

f5c913bc9e815b4919bec4db9c81d29d21972ba1 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/f5c913bc9e815b4919bec4db9c81d29d21972ba1
Authored: 2025-09-08 17:59:28 +0200
Committed: 2025-09-08 17:59:28 +0200

[Editor] Make sure the comment button is at the right place when adding it in the toolbar

Files Modified:

• src/display/editor/comment.js
• src/display/editor/editor.js
• src/display/editor/toolbar.js

---

94d72e903face36d62ab08b521c9a00a0e3cbfd0 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/94d72e903face36d62ab08b521c9a00a0e3cbfd0
Authored: 2025-09-08 16:36:46 +0200
Committed: 2025-09-08 17:40:47 +0200

[Editor] Add the dates and rich text if any to the editors in order to use them when displaying the popup

Files Modified:

• src/display/editor/comment.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/ink.js
• src/display/editor/stamp.js

---

54351ee4379dd1712781666a121d6f52e91904b5 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/54351ee4379dd1712781666a121d6f52e91904b5
Authored: 2025-09-08 17:13:07 +0200
Committed: 2025-09-08 17:13:37 +0200

[Editor] When clicking on a comment in the sidebar, wait for the annotation editor layer to be rendered

and add a getter for the layer bounding rect.

Files Modified:

• src/display/editor/annotation_editor_layer.js
• src/display/editor/tools.js
• web/comment_manager.js

---

2d5794f79d9fa05187510df0e3e9eddec5aa3635 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/2d5794f79d9fa05187510df0e3e9eddec5aa3635
Authored: 2025-09-08 15:36:41 +0200
Committed: 2025-09-08 15:36:41 +0200

[Editor] Fix saving a deleted popup

Files Modified:

• src/core/annotation.js
• src/core/primitives.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/ink.js
• src/display/editor/signature.js
• src/display/editor/stamp.js
• test/unit/annotation_spec.js

---

f9be06a8c1573de889a92c96f8b5f07fa05c6a5c by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/mozilla/pdf.js/+/f9be06a8c1573de889a92c96f8b5f07fa05c6a5c
Authored: 2025-09-08 12:31:52 +0000
Committed: 2025-09-08 12:31:52 +0000

Bump actions/setup-node from 4 to 5

Bumps actions/setup-node from 4 to 5.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: actions/setup-node
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/ci.yml
• .github/workflows/font_tests.yml
• .github/workflows/lint.yml
• .github/workflows/publish_release.yml
• .github/workflows/publish_website.yml
• .github/workflows/types_tests.yml

---

a5ef8ca82810d0d0eb587f56381bc3597d74431c by dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

https://github.com/mozilla/pdf.js/+/a5ef8ca82810d0d0eb587f56381bc3597d74431c
Authored: 2025-09-08 12:26:36 +0000
Committed: 2025-09-08 12:26:36 +0000

Bump actions/setup-python from 5 to 6

Bumps actions/setup-python from 5 to 6.

• Release notes
• Commits

---

updated-dependencies:

• dependency-name: actions/setup-python
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
  ...

Signed-off-by: dependabot[bot] <[e-mail]>

Files Modified:

• .github/workflows/fluent_linter.yml
• .github/workflows/font_tests.yml

---

f1f8ee47ff39cc99c9d016037194a500542e6004 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/f1f8ee47ff39cc99c9d016037194a500542e6004
Authored: 2025-09-07 18:35:17 +0200
Committed: 2025-09-07 18:35:17 +0200

Fix the rendering of XFA rich text in popup annotations

Before the introduction of the renderRichText helper function we
exclusively used this.#html for XFA rich text and exclusively used
this.#contentsObj for plain text. However, after the refactoring we
tried to access this.#contentsObj.dir in both cases, which fails for
XFA rich text because this.#contentsObj is null in that case.

This commit fixes the issue by using optional chaining to make sure we
don't try to access non-existent this.#contentsObj properties, which
makes the must update an existing annotation and show the right popup
freetext integration pass again.

Fixes #20237.
Fixes 35c90984.

Files Modified:

• src/display/annotation_layer.js

---

7f74fbf8fd0043a9470dabd055d1953d956c6477 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/7f74fbf8fd0043a9470dabd055d1953d956c6477
Authored: 2025-08-17 17:10:58 +0200
Committed: 2025-09-07 14:39:52 +0200

Fix block spacing inconsistencies in the integration test code

Most places have a newline before/after before{Each,All},
after{Each,All} and it to visually separate the blocks for clarity,
but in a handful of places this wasn't done. This commit removes the
inconsistencies so that the test code is formatted consistently.

Files Modified:

• test/integration/text_layer_spec.mjs
• test/integration/viewer_spec.mjs

---

cf5bffef2e3309cc2e228fb2f69a56c48950f7c2 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/cf5bffef2e3309cc2e228fb2f69a56c48950f7c2
Authored: 2025-08-17 16:04:50 +0200
Committed: 2025-09-07 14:39:52 +0200

Use the getAnnotationSelector helper function more in the integration test code

The helper function was used in a number of places, but also a lot of
places contained the annotation selector string inline. This commit
makes sure that all places use getAnnotationSelector consistently to
make sure the annotation selector string is only defined in a single
place and to improve readability of the test code.

Files Modified:

• test/integration/annotation_spec.mjs
• test/integration/freetext_editor_spec.mjs
• test/integration/highlight_editor_spec.mjs
• test/integration/scripting_spec.mjs

---

c09ad5a2ce47d79e2e8f451e1b697bb262eab3be by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/c09ad5a2ce47d79e2e8f451e1b697bb262eab3be
Authored: 2025-08-17 15:16:29 +0200
Committed: 2025-09-07 14:39:48 +0200

Use the closePages helper function more in the integration test code

This test called closeSinglePage manually at the end of the test,
which is inconsistent with all other tests that call closePages in an
afterEach block. This commit fixes the difference for consistency.

Files Modified:

• test/integration/scripting_spec.mjs

---

35c909843beeba5a60114a68e8c8ad6cb87888c1 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/35c909843beeba5a60114a68e8c8ad6cb87888c1
Authored: 2025-09-04 14:53:22 +0200
Committed: 2025-09-04 22:27:31 +0200

Add a new function renderRichText to be used in the annotation layer

and which will be used in order to make the contents of the new popup used for comments.

Files Modified:

• src/display/annotation_layer.js
• src/display/display_utils.js
• src/pdf.js
• test/unit/display_utils_spec.js
• test/unit/pdf_spec.js
• web/pdfjs.js

---

2354ae42332a4a070eb547d89161618786661590 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/2354ae42332a4a070eb547d89161618786661590
Authored: 2025-09-04 18:54:10 +0200
Committed: 2025-09-04 18:54:13 +0200

[Editor] Don't save the image when updating a stamp annotation

It adds some useless bytes in the file.

Files Modified:

• src/display/editor/stamp.js

---

ca280399c2182986c653ff9447a5d72db2839807 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/ca280399c2182986c653ff9447a5d72db2839807
Authored: 2025-08-31 22:32:11 +0200
Committed: 2025-09-02 21:17:08 +0200

[Editor] Use the color of the annotation for the background of the comment button

Files Modified:

• src/display/annotation_layer.js
• src/display/display_utils.js
• src/display/editor/comment.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/ink.js
• src/display/editor/stamp.js
• src/pdf.js
• test/unit/display_utils_spec.js
• test/unit/pdf_spec.js
• web/comment_manager.css
• web/pdfjs.js

---

dd4b475109e6693419850c4775f5accc95cbfeec by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/dd4b475109e6693419850c4775f5accc95cbfeec
Authored: 2025-08-31 23:21:19 +0200
Committed: 2025-08-31 23:21:19 +0200

[Editor] Make scrollable the area containing the comments in the sidebar

Files Modified:

• web/comment_manager.css
• web/viewer.html

---

2a459857cecaef0713af55168ee59fb3374ff3e1 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/2a459857cecaef0713af55168ee59fb3374ff3e1
Authored: 2025-08-30 18:56:21 +0200
Committed: 2025-08-31 19:59:16 +0200

[Editor] Add editors with a comment in the sidebar

and add a button close to the editor.
Clicking on the button will display a popup with the comment but it's for a next patch.

Files Modified:

• src/display/editor/annotation_editor_layer.js
• src/display/editor/comment.js
• src/display/editor/drawers/freedraw.js
• src/display/editor/drawers/highlight.js
• src/display/editor/editor.js
• src/display/editor/highlight.js
• src/display/editor/toolbar.js
• src/display/editor/tools.js
• web/comment_manager.css
• web/comment_manager.js

---

5a7c8726183e0e5063309accc4045471e3c170da by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/5a7c8726183e0e5063309accc4045471e3c170da
Authored: 2025-08-31 16:26:03 +0200
Committed: 2025-08-31 16:26:03 +0200

[Editor] Hide the comment sidebar on document change

If the document changes the comment state from the old document should
be replaced with that of the new document. To do this the comment
manager is destroyed, but the corresponding comment sidebar wasn't
destroyed yet, which resulted in the comment state from the old document
still being visible for the new document.

This commit fixes the issue by hiding the comment sidebar if the comment
manager is destroyed. Note that hiding the comment sidebar effectively
destroys all its state, and we already set the annotation mode to "none"
on document change so we don't want to keep showing the comment sidebar
anyway.

Files Modified:

• web/comment_manager.js

---

0ec503e5ef5bf3d762703141c9178ef60211f664 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/0ec503e5ef5bf3d762703141c9178ef60211f664
Authored: 2025-08-26 22:04:57 +0200
Committed: 2025-08-30 21:18:12 +0200

Add a function changeLightness in order to change the lightness of a RGB color

Files Modified:

• src/display/annotation_layer.js
• src/display/display_utils.js
• src/pdf.js
• test/unit/display_utils_spec.js
• test/unit/pdf_spec.js
• web/comment_manager.js
• web/pdfjs.js

---

cac052c0be23a6c123d9f231f3688e76957420c1 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/cac052c0be23a6c123d9f231f3688e76957420c1
Authored: 2025-08-30 18:39:19 +0200
Committed: 2025-08-30 18:39:19 +0200

Update translations to the most recent versions

Files Modified:

• l10n/ach/viewer.ftl
• l10n/af/viewer.ftl
• l10n/an/viewer.ftl
• l10n/ar/viewer.ftl
• l10n/ast/viewer.ftl
• l10n/az/viewer.ftl
• l10n/be/viewer.ftl
• l10n/bg/viewer.ftl
• l10n/bn/viewer.ftl
• l10n/bo/viewer.ftl
• l10n/br/viewer.ftl
• l10n/brx/viewer.ftl
• l10n/bs/viewer.ftl
• l10n/ca/viewer.ftl
• l10n/cak/viewer.ftl
• l10n/ckb/viewer.ftl
• l10n/cs/viewer.ftl
• l10n/cy/viewer.ftl
• l10n/da/viewer.ftl
• l10n/de/viewer.ftl
• l10n/dsb/viewer.ftl
• l10n/el/viewer.ftl
• l10n/en-CA/viewer.ftl
• l10n/en-GB/viewer.ftl
• l10n/eo/viewer.ftl
• l10n/es-AR/viewer.ftl
• l10n/es-CL/viewer.ftl
• l10n/es-ES/viewer.ftl
• l10n/es-MX/viewer.ftl
• l10n/et/viewer.ftl
• l10n/eu/viewer.ftl
• l10n/fa/viewer.ftl
• l10n/ff/viewer.ftl
• l10n/fi/viewer.ftl
• l10n/fr/viewer.ftl
• l10n/fur/viewer.ftl
• l10n/fy-NL/viewer.ftl
• l10n/ga-IE/viewer.ftl
• l10n/gd/viewer.ftl
• l10n/gl/viewer.ftl
• l10n/gn/viewer.ftl
• l10n/gu-IN/viewer.ftl
• l10n/he/viewer.ftl
• l10n/hi-IN/viewer.ftl
• l10n/hr/viewer.ftl
• l10n/hsb/viewer.ftl
• l10n/hu/viewer.ftl
• l10n/hy-AM/viewer.ftl
• l10n/hye/viewer.ftl
• l10n/ia/viewer.ftl
• l10n/id/viewer.ftl
• l10n/is/viewer.ftl
• l10n/it/viewer.ftl
• l10n/ja/viewer.ftl
• l10n/ka/viewer.ftl
• l10n/kab/viewer.ftl
• l10n/kk/viewer.ftl
• l10n/km/viewer.ftl
• l10n/kn/viewer.ftl
• l10n/ko/viewer.ftl
• l10n/lij/viewer.ftl
• l10n/lo/viewer.ftl
• l10n/lt/viewer.ftl
• l10n/ltg/viewer.ftl
• l10n/lv/viewer.ftl
• l10n/meh/viewer.ftl
• l10n/mk/viewer.ftl
• l10n/ml/viewer.ftl
• l10n/mr/viewer.ftl
• l10n/ms/viewer.ftl
• l10n/my/viewer.ftl
• l10n/nb-NO/viewer.ftl
• l10n/ne-NP/viewer.ftl
• l10n/nl/viewer.ftl
• l10n/nn-NO/viewer.ftl
• l10n/oc/viewer.ftl
• l10n/pa-IN/viewer.ftl
• l10n/pl/viewer.ftl
• l10n/pt-BR/viewer.ftl
• l10n/pt-PT/viewer.ftl
• l10n/rm/viewer.ftl
• l10n/ro/viewer.ftl
• l10n/ru/viewer.ftl
• l10n/sat/viewer.ftl
• l10n/sc/viewer.ftl
• l10n/sco/viewer.ftl
• l10n/si/viewer.ftl
• l10n/sk/viewer.ftl
• l10n/skr/viewer.ftl
• l10n/sl/viewer.ftl
• l10n/son/viewer.ftl
• l10n/sq/viewer.ftl
• l10n/sr/viewer.ftl
• l10n/sv-SE/viewer.ftl
• l10n/szl/viewer.ftl
• l10n/ta/viewer.ftl
• l10n/te/viewer.ftl
• l10n/tg/viewer.ftl
• l10n/th/viewer.ftl
• l10n/tl/viewer.ftl
• l10n/tr/viewer.ftl
• l10n/trs/viewer.ftl
• l10n/uk/viewer.ftl
• l10n/ur/viewer.ftl
• l10n/uz/viewer.ftl
• l10n/vi/viewer.ftl
• l10n/xh/viewer.ftl
• l10n/zh-CN/viewer.ftl
• l10n/zh-TW/viewer.ftl

---

4dcfc967036223f714210ec6ecfd9eba8376d54b by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/4dcfc967036223f714210ec6ecfd9eba8376d54b
Authored: 2025-08-30 18:36:45 +0200
Committed: 2025-08-30 18:38:25 +0200

Update dependencies to the most recent versions

Files Modified:

• gulpfile.mjs
• package-lock.json
• package.json

---

a5456033ce6cb90c05203733e26196c6c65eba85 by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/a5456033ce6cb90c05203733e26196c6c65eba85
Authored: 2025-08-30 17:49:19 +0200
Committed: 2025-08-30 17:49:19 +0200

Bump the stable version in pdfjs.config

Files Modified:

• pdfjs.config

---

25990e4287a1f46cb1bb57a15c122061dd8cba0b by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/25990e4287a1f46cb1bb57a15c122061dd8cba0b
Authored: 2025-08-27 17:11:22 +0200
Committed: 2025-08-29 16:00:06 +0200

[Editor] Add a sidebar allowing the user to navigate between the comments in a pdf (bug 1985567)

This implements what has been specified but it's still not done: we have to handle editing a comment
or an annotation containing one.

Files Added:

• web/sidebar.css

Files Modified:

• l10n/en-US/viewer.ftl
• src/display/editor/tools.js
• src/shared/util.js
• web/app.js
• web/comment_manager.css
• web/comment_manager.js
• web/pdf_viewer.css
• web/toolbar.js
• web/viewer.css
• web/viewer.html
• web/viewer.js

---

3e01ee9bb778d05b589ed64794a5d60d65ae5888 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/3e01ee9bb778d05b589ed64794a5d60d65ae5888
Authored: 2025-08-28 22:38:05 +0200
Committed: 2025-08-28 22:38:05 +0200

Reset editing mode when changing the pdf document

Files Modified:

• web/pdf_viewer.js

---

0a4817fb712bf4abc77be8f0335da50af8cf0b76 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/0a4817fb712bf4abc77be8f0335da50af8cf0b76
Authored: 2025-08-28 16:09:58 +0200
Committed: 2025-08-28 16:09:58 +0200

[Editor] Fix unit (for consistency) and remove few useless px

Files Modified:

• web/annotation_editor_layer_builder.css

---

1876013e4e6c654797ae877b8d5e509c989802ce by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/1876013e4e6c654797ae877b8d5e509c989802ce
Authored: 2025-08-27 16:01:29 +0200
Committed: 2025-08-27 16:01:29 +0200

[Editor] Fix the dimensions of the comment icon

Files Modified:

• web/images/comment-editButton.svg

---

e44e470eb232c0762a90b8b61a90bb277c9239bf by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/e44e470eb232c0762a90b8b61a90bb277c9239bf
Authored: 2025-08-26 14:54:16 +0200
Committed: 2025-08-26 22:06:49 +0200

[Editor] Remove useless CSS and fix styling for the comment button

Files Modified:

• src/display/annotation_layer.js
• web/comment_manager.css

---

1fc039e14f1b04887437e4ebb48394bf9d5eedf3 by Calixte Denizet <[e-mail]>

https://github.com/mozilla/pdf.js/+/1fc039e14f1b04887437e4ebb48394bf9d5eedf3
Authored: 2025-08-25 22:47:13 +0200
Committed: 2025-08-26 19:40:41 +0200

[Editor] Add a method to get an editor rect in the pdf page coordinates

Files Modified:

• src/display/editor/draw.js
• src/display/editor/editor.js
• src/display/editor/freetext.js
• src/display/editor/highlight.js
• src/display/editor/stamp.js

---

11d5d6d0ce1c30eb790a26e832b9e42a2caefc1d by Tim van der Meij <[e-mail]>

https://github.com/mozilla/pdf.js/+/11d5d6d0ce1c30eb790a26e832b9e42a2caefc1d
Authored: 2025-08-25 20:02:32 +0200
Committed: 2025-08-25 20:09:32 +0200

Skip the curvature ink editor integration test for Chrome on Windows

This test permafails for that particular OS/browser combination.

Fixes 18d3dc18.

Files Modified:

• test/integration/ink_editor_spec.mjs

---

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=087831f9f08ae35cb1735b92a85c037717a25c6b

Comment 3

[Update Bot]

Attachment: Bug 1988516 - Update PDF.js to 3432c1933e251e4280a029a1308578b422f36b99

Comment 4

[Update Bot]

All jobs completed, we found the following issues.

Known Issues:

• browser/base/content/test/static/browser_parsable_css.js
  - test-linux2404-64/opt-mochitest-browser-chrome-spi-nw-1 (IZbsqdEMT2CGM_UNPYqBMw)
  - test-linux2404-64/opt-mochitest-browser-chrome-swr-a11y-checks-1 (URsrEUrsSXCSgpLR4Fw8gg)
  - test-windows11-32-24h2/opt-mochitest-browser-chrome-1 (eA9kL0RSQyuDEswei-ggJg)
  - test-windows11-64-24h2/opt-mochitest-browser-chrome-1 (LYfpopHVRRirwgxPhg1QLA)
  - test-windows11-64-24h2/opt-mochitest-browser-chrome-spi-nw-1 (QDAQoTJtTQm5DW6gBNqS3A)
  - test-macosx1015-64-qr/opt-mochitest-browser-chrome-1 (bbIHX5BAQviaefJNPKjcDA)
  - test-macosx1015-64-qr/opt-mochitest-browser-chrome-spi-nw-1 (DxBQGPHuRkCekMmmemIUAw)
  - test-linux2404-64/opt-mochitest-browser-chrome-swr-1 (GG1xuB0mQfuVLcsKSQ1zGg)

• toolkit/components/pdfjs/test/browser_pdfjs_editing_contextmenu.js
  - test-linux2404-64/opt-mochitest-browser-chrome-spi-nw-1 (IZbsqdEMT2CGM_UNPYqBMw)

These failures may mean that the library update succeeded; you'll need to review
them yourself and decide. If there are lint failures, you will need to fix them in
a follow-up patch. (Or ignore the patch I made, and recreate it yourself with
./mach vendor toolkit/components/pdfjs/moz.yaml.)

In either event, I have done all I can, so you will need to take it from here.
When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.