1988631 - `moz-phab submit`: avoid revset syntax errors with start and end range query

Status: RESOLVED FIXED

(Conduit :: moz-phab, enhancement)

Description

[Erich Gubler [:ErichDonGubler] (he/him)]

moz-phab version (from moz-phab version): 2.0.0 and later

Comment 1

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1988631 - fix(jujutsu): avoid revset syntax errors w/ `{start}::{end}` r=sheehan

This improves diagnostics with revsets that may otherwise be
syntactically invalid. For instance, a user might instinctively specify
<start>::<end> instead of two separate start and end CLI
arguments, which would produce this error diagnostic:

CommandError: command 'jj' failed to complete successfully
Run moz-phab again with '--trace' to show debugging output

With this change, the diagnostic changes to:

Multiple parents found for change <snip>, unable to continue

…which does a much better job of hinting that the argument is expected
to unambiguously refer to a single change, rather than refer to a range.

Comment 2

[BMO Github Automation]

Authored by https://github.com/ErichDonGubler
https://github.com/mozilla-conduit/review/commit/ed58db5484d647bfc644152547780a5318a76722
[main] Bug 1988631 - fix(jujutsu): avoid revset syntax errors w/ {start}::{end} r=sheehan