1988638 - Bookmarks UI "sign in to sync" button has an odd rounded background on "Sign in to sync" button, causing a double-button effect and bad contrast

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, defect, P2)

Description

[Daniel Holbert [:dholbert]]

Steps to reproduce

1. Be using Firefox Nightly with a fresh profile (or at least one where you're not signed in to Sync and have no bookmarks saved).
2. Ensure Firefox Nightly is using its dark theme (either by changing your Android system-theme, or by going to Firefox's Settings|Customize|Theme-->Dark).
3. Tap the 3-dot-menu and choose "Bookmarks", and look at the "Sign in to sync" button.

Expected behavior

Button should look nice and have readable text.

Actual behavior

The button has two different backgrounds (a light-purple rectangle, and a dark-purple foreground with more-rounded corners)
The foreground background-color makes the text hard to read (black text on dark purple).

Device information

• Firefox version: Nightly 144.0a1 2025-09-13
• Android device model: Pixel 6a
• Android OS version: 16

Any additional information?

Can't reproduce in Firefox 143b9, so this is a regression. (In that version, the text is white and the whole button is dark-purple)

Comment 1

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)

2. Ensure Firefox Nightly is using its dark theme

Note: there's no issue in the "light" theme. We show a single dark-purple button with light text there.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: screenshot of "good" results in Firefox Beta 143b9

Comment 4

[Daniel Holbert [:dholbert]]

Regression range:
Newest known good nightly: 2025-08-25
Oldest known bad nightly: 2025-08-26

https://hg-edge.mozilla.org/mozilla-central/pushloghtml?fromchange=9426f4b06a46&tochange=b7573b229c2d

Suspected regressor:
https://hg-edge.mozilla.org/mozilla-central/rev/28bf7f27cd69b32b8e84ef560ebf816d4d99af0c
iorgamgabriel — Bug 1973829 - Replace the TextButtons in Bookmarks to use our reusable component r=android-reviewers,calu,007

Comment 5

[Daniel Holbert [:dholbert]]

Hi Gabriel - this appears to be a regression from bug 1973829, affecting Nightly and now 144beta - could you take a look when you get a chance?

Comment 6

[Noah Bond [:007]]

This should be a quick fix. It looks like we just need to remove the color overrides from this blob, and let the reusable component handle the size and colors

Comment 7

[Iorga Gabriel]

Attachment: Bug 1988638 - Fix UI for Bookmarks "sign in to sync" button.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a9e2f7cecab0
https://hg.mozilla.org/integration/autoland/rev/76437befd071
Fix UI for Bookmarks "sign in to sync" button. r=android-reviewers,007

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/76437befd071

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox144 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Mira Lobontiu (Android QA)]

Attachment: 1988638.png

Verified as fixed on the latest Firefox for Android Nightly 145.0a1 from 9/24 using a Samsung Galaxy S24 (Android 15).