1988751 - Disable ABA notification permission request

Status: RESOLVED FIXED

(Core :: DOM: Notifications, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Looks like there's no real web use for ABA request. https://glam.telemetry.mozilla.org/fog/probe/web_notification_request_permission_origin/explore?activeBuckets=%5B%22first_party%22%2C%22third_party%22%2C%22nested_first_party%22%5D&app_id=release&timeHorizon=ALL

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1988751 - Forbid notification permission in nested first party iframes r=asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4996f57d97c9
https://hg.mozilla.org/integration/autoland/rev/801c724c16e8
Forbid notification permission in nested first party iframes r=asuth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9b6a23ed9be0
https://hg.mozilla.org/integration/autoland/rev/0fcc319020e0
Revert "Bug 1988751 - Forbid notification permission in nested first party iframes r=asuth" for causing multiple failures

Comment 4

[amarc]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log
• Failure Log 2

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Ah, xorigin.

And the test should be done in WPT instead - the log 2.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d42b499951c3
https://hg.mozilla.org/integration/autoland/rev/0efcee23ceeb
Forbid notification permission in nested first party iframes r=asuth

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55039 for changes under testing/web-platform/tests

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/0efcee23ceeb

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Disabling unused code path in all channels
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Telemetry says this code is not being used in the real world.
• String changes made/needed: No
• Is Android affected?: yes

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1988751 - Forbid notification permission in nested first party iframes r=asuth

Original Revision: https://phabricator.services.mozilla.com/D265282

Comment 12

[Phabricator Automation]

firefox-esr140 Uplift Approval Request

• User impact if declined: Disabling unused code path in all channels
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Telemetry says this code path is not being used in the real world
• String changes made/needed: No
• Is Android affected?: yes

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1988751 - Forbid notification permission in nested first party iframes r=asuth

Original Revision: https://phabricator.services.mozilla.com/D265282

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr140/rev/6a6f1e4d145b

Comment 15

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8a06f8a260f4
https://hg.mozilla.org/releases/mozilla-beta/rev/7cb876af22f4