1988767 - The label for the calendar Properties button in the calendar creation dialog shows "null"

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Brendan Abolivier [:babolivier]]

Attachment: Screenshot From 2025-09-16 16-03-10.png

I've observed this with the current nightly; see the attached screenshot.

Mozregression says the regression range is https://hg-edge.mozilla.org/comm-central/pushloghtml?fromchange=ac711dc11260f30b88c66f3276d9b9f98685e369&tochange=ae44ce1e2466c5413955cd09268069c5c9cf9af7

I'm not seeing anything that seems related in there, so maybe the source is a m-c change?

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/9f52929439ab1c3441306c679e7ad0a4f1c834cf/calendar/base/content/dialogs/calendar-creation.js#510,534

https://hg-edge.mozilla.org/comm-central/rev/ac711dc11260f30b88c66f3276d9b9f98685e369#l5.30 - didn't account for this

Comment 2

[Toby Pilling [:tobyp]]

Attachment: Bug 1988767 - Add missing Properties label to calendar-creation dialog. r=#thunderbird-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4d6a057f8b7
Add missing Properties label to calendar-creation dialog. r=aleca

Comment 4

[Brendan Abolivier [:babolivier]]

Toby, should we uplift this fix? The regressor patch landed in the 144 branch.

Comment 5

[Toby Pilling [:tobyp]]

Comment on attachment 9513596 [details]
Bug 1988767 - Add missing Properties label to calendar-creation dialog. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Simple fix. Don't want the problem to make it's way to monthly release.
• User impact if declined: Users will see "null" as the button label when subscribing to network calendars.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One line change to pull in fluent string
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 6

[Corey Bryant]

Comment on attachment 9513596 [details]
Bug 1988767 - Add missing Properties label to calendar-creation dialog. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 144.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/32bc56679561