Closed
Bug 1988793
Opened 8 months ago
Closed 8 months ago
Paint and Overflow support for text-decoration-trim
Categories
(Core :: Layout: Text and Fonts, enhancement)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
145 Branch
| Tracking | Status | |
|---|---|---|
| firefox145 | --- | fixed |
People
(Reporter: alaskanemily, Assigned: alaskanemily)
References
Details
(Whiteboard: [jp-mvp])
Attachments
(1 file)
This represents the changes specifically to paint and overflow code to support non-zero text-decoration-trim.
This can be implemented right now without any further dependency and before the intricacies of actually calculating this value for each text frame, as at the CSS rendering level this should be quite simple.
Without enabling the pref, this code will always use the default value, which is the same as not implementing text-decoration-trim, so this can be landed first without any problems.
bug 1979915, the original bug, still encompasses the work to calculate what the correct offsets are.
Updated•8 months ago
|
Points: --- → 2
Whiteboard: [jp-triage] → [jp-mvp]
| Assignee | ||
Comment 1•8 months ago
|
||
This currently is never set, it will be populated from the geometry of the
frame from which the decoration style comes from in Bug 1979915.
Updated•8 months ago
|
Assignee: nobody → emcdonough
Status: NEW → ASSIGNED
Pushed by emcdonough@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c7b82ce2af10
https://hg.mozilla.org/integration/autoland/rev/375900adf04b
Add trim modifier for text decoration rect calculation and decoration painting r=layout-jp-market-reviewers,jfkthame
Comment 3•8 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox145:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Updated•7 months ago
|
QA Whiteboard: [qa-triage-done-c146/b145]
You need to log in
before you can comment on or make changes to this bug.
Description
•