1988794 - Horizontal tabs should use same radius as vertical tabs

Status: RESOLVED FIXED

(Firefox :: Theme, task, P3)

Description

[Jules Simplicio [:jules]]

Today, horizontal tabs have a 4px radius in contrast to vertical tabs' 8px. Let's make our tabs match radiuses in both orientations. UX prefers roundier so we will stick to --border-radius-medium (8px) and assign it here too.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1988794 - Increase --tab-border-radius to larger value from vertical tabs. r?jules

Comment 2

[Dão Gottwald [:dao]]

I think we should fix this before getting started with bug 1988809.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d5770dd3a8e0
https://hg.mozilla.org/mozilla-central/rev/eb4cc6a1344e
Increase --tab-border-radius to larger value from vertical tabs. r=jules,desktop-theme-reviewers,tabbrowser-reviewers,sthompson

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/eb4cc6a1344e

Comment 5

[Dão Gottwald [:dao]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Some users are passionate about visual changes, so we think it might be a good idea to be upfront that we've done this and why. This is a shared request for this bug and bug 1965867.
[Affects Firefox for Android]: no
[Suggested wording]: Horizontal tabs are now slightly more round, following the look of vertical tabs. Buttons and text inputs, including the Address bar, have been updated as well for consistency.
[Links (documentation, blog post, etc)]:

Comment 6

[Pascal Chevrel:pascalc]

Note added to the Changed section of our release notes. I am keeping the release-firefox tracking flag set to? until we include this note into our final release notes in November. Thanks!

Comment 7

[Alex Finder| PTO returning Dec. 8th]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d5770dd3a8e0
https://hg.mozilla.org/mozilla-central/rev/eb4cc6a1344e
Increase --tab-border-radius to larger value from vertical tabs.
r=jules,desktop-theme-reviewers,tabbrowser-reviewers,sthompson

Perfherder has detected a browsertime performance change from push eb4cc6a1344ed84c4c597ce598dd300ce82616da.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
9%	google-search LastVisualChange	linux1804-64-shippable-qr	cold fission webrender	873.62 -> 792.15	Before/After
7%	google-search LastVisualChange	linux1804-64-shippable-qr	cold fission webrender	867.99 -> 810.11	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 46971

The following documentation link provides more information about this command.

Comment 8

[Pascal Chevrel:pascalc]

Added to our final 145 release notes.