1988818 - [wpt-sync] Sync PR 54848 - [ReferenceTarget] Make IDL attribute nullable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54848 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54848
Details from upstream follow.

Daniel Clark <[e-mail]> wrote:

[ReferenceTarget] Make IDL attribute nullable

Per https://github.com/WICG/webcomponents/issues/1093 the
referenceTarget IDL attribute should be a nullable DOMString.
Update the types in the Blink implementation accordingly.
Update the reference-target-basic.html WPT that's affected by this.
Add coverage to the reference target WPTs for aria-labeledby,
commandfor, interestfor, and popovertarget to validate that setting
referenceTarget to null makes idrefs target the host, and setting
referenceTarget to the empty string makes them invalid.

Bug: 346835896
Change-Id: I7699d7ebcb9bf50db15a54336ad0acf05379f71c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6943596
Commit-Queue: Dan Clark \<[e-mail]>
Reviewed-by: Alice Boxhall \<[e-mail]>
Reviewed-by: Mason Freed \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1515789}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 13 tests and 6 subtests

## Status Summary

### Firefox
`OK`   : 5[GitHub] 11[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`PASS` : 1[GitHub] 4520[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`FAIL` : 19[GitHub] 1681[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]
`ERROR`: 2

### Chrome
`OK`   : 5
`PASS` : 8
`FAIL` : 12

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=1224e51279ed7dbaa907d8bd1184e4cc5a5cbd95)
[GitHub PR Head](https://wpt.fyi/results/?sha=aa02f1332a39f463f92667bbe2ea668a3810ca22&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=aa02f1332a39f463f92667bbe2ea668a3810ca22&label=pr_base)

## Details

(See attachment for full changes)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1286cb27f08
https://hg.mozilla.org/integration/autoland/rev/324baec346cb
[wpt PR 54848] - [ReferenceTarget] Make IDL attribute nullable, a=testonly
https://github.com/mozilla-firefox/firefox/commit/fa8c55e30a98
https://hg.mozilla.org/integration/autoland/rev/28e8304a90b2
[wpt PR 54848] - Update wpt metadata, a=testonly

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/324baec346cb
https://hg.mozilla.org/mozilla-central/rev/28e8304a90b2