1988868 - Open devtools on a page with many grid elements makes the tab hang

Status: RESOLVED FIXED

(DevTools :: Inspector: Layout, defect, P2)

Description

[Julian Descottes [:jdescottes]]

STRs:

• open https://bug1987193.bmoattachments.org/attachment.cgi?id=9511747
• click the Expand All button
• open devtools inspector

The browser will be very slow / might freeze.
This is related to the creation of our grid actors.

A first part of the fix landed in Bug 1707808, and there is a detailed analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=1707808#c10

What is left (and prototyped in a hacky patch) is to stop calling getGridFragments upfront for each grid actor. Instead this should be done lazily / ondemand.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1988868 - [devtools] Improve performance of layout panel on pages with many grid elements

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1988868 - [devtools] Improve performance of layout panel on pages with many grid elements

iDifferential Revision: https://phabricator.services.mozilla.com/D264256

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1988868 - [devtools] Add DAMP test for inspector layout panel with many grid containers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/18007e570851
https://hg.mozilla.org/integration/autoland/rev/d1a163d6664f
[devtools] Add DAMP test for inspector layout panel with many grid containers r=perftest-reviewers,devtools-reviewers,aglavic,ochameau
https://github.com/mozilla-firefox/firefox/commit/57da0db2b297
https://hg.mozilla.org/integration/autoland/rev/0fa16a70e8d7
[devtools] Improve performance of layout panel on pages with many grid elements r=devtools-reviewers,devtools-backward-compat-reviewers,ochameau

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d1a163d6664f
https://hg.mozilla.org/mozilla-central/rev/0fa16a70e8d7