1988948 - Test S/MIME certificate for sub-identity doesn't work

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Magnus Melin [:mkmelin]]

While bug 1944810 worked for one of my test certificates, when I go to a sub-identity and try Test of a certificate I have, hitting Test does nothing.

Uncaught (in promise) NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIX509CertDB.asyncVerifyCertAtTime]
    smimeTestCert chrome://messenger/content/am-e2e.js:783
    oncommand chrome://messenger/content/am-identity-edit.xhtml:1
2 am-e2e.js:783

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1988948 - Test S/MIME certificate for sub-identity doesn't work. r=kaie

Comment 2

[Kai Engert [:KaiE:]]

Bug 1985660 changed the parameter list for 1985660.

We also need to fix mailnews/mime/test/unit/test_smime_perm_decrypt.js

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1988948 - Adjust test after parameters for asyncVerifyCertAtTime were changed. r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ad654d0a384
Test S/MIME certificate for sub-identity doesn't work. r=kaie
https://hg.mozilla.org/comm-central/rev/2d672cbd8f7e
Adjust test after parameters for asyncVerifyCertAtTime were changed. r=mkmelin

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1988948 - hook up testCertValidity() in test_smime_perm_decrypt.js. r=kaie

This doesn't add any checks for expected results but at least we run through the code.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e54474f36a1d
hook up testCertValidity() in test_smime_perm_decrypt.js. r=kaie

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9513685 [details]
Bug 1988948 - Test S/MIME certificate for sub-identity doesn't work. r=kaie

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Regression
  (All patches needed)
• User impact if declined: Feature completely broken
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): API adjustment
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 8

[Corey Bryant]

Comment on attachment 9513685 [details]
Bug 1988948 - Test S/MIME certificate for sub-identity doesn't work. r=kaie

[Triage Comment]
Approved for beta

Comment 9

[Corey Bryant]

Comment on attachment 9513706 [details]
Bug 1988948 - Adjust test after parameters for asyncVerifyCertAtTime were changed. r=mkmelin

[Triage Comment]
Approved for beta

Comment 10

[Corey Bryant]

Comment on attachment 9514261 [details]
Bug 1988948 - hook up testCertValidity() in test_smime_perm_decrypt.js. r=kaie

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 144.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/52905733c4c7
https://hg.mozilla.org/releases/comm-beta/rev/a77172d3d7ff
https://hg.mozilla.org/releases/comm-beta/rev/2ec1fd615b64