1988950 - Test S/MIME certificate doesn't work for an old invalid cert

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Magnus Melin [:mkmelin]]

Another one of my (old) s/mime certificates can also not be tested.
Hitting Test results in nothing

Uncaught (in promise) NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIX509CertDB.findCertByDBKey]
    smimeTestCert chrome://messenger/content/am-e2e.js:770
    oncommand chrome://messenger/content/am-identity-edit.xhtml:1
2 am-e2e.js:770

I mean, sure that old cert is not valid. But the point of the button is to be able to Test that.
There are two cases of NS_ERROR_ILLEGAL_VALUE in https://searchfox.org/comm-central/source/mozilla/security/manager/ssl/nsNSSCertificateDB.cpp#62 - I can debug if needed. But idk, the cert will be invalid (though it was valid some time in the distant past).

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: Bug 1988950 - Test S/MIME certificate doesn't work for an old invalid cert. r=kaie

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40d997681be9
Test S/MIME certificate doesn't work for an old invalid cert. r=kaie

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9513687 [details]
Bug 1988950 - Test S/MIME certificate doesn't work for an old invalid cert. r=kaie

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Feature not completely working
• User impact if declined: Button may not work
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined change
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 4

[Corey Bryant]

Comment on attachment 9513687 [details]
Bug 1988950 - Test S/MIME certificate doesn't work for an old invalid cert. r=kaie

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 144.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a6d13d509fa2