1988988 - Add extension API support for masque proxy

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement, P3)

Description

[Valentin Gosu [:valentin]]

The webextension proxy api currently supports HTTP/S or SOCKS proxies.
The new MASQUE connect-udp proxies are similar to HTTPS proxies, but the proxyInfo needs to contain the pathTemplate.
This bug covers the webextension API + tests

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1988988 - Add extension API support for masque proxy r=#necko

Comment 2

[Rob Wu [:robwu]]

(moving to WebExtensions component for better visibility; the meta bug already tracks the work at the Networking level)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b36b73270863
https://hg.mozilla.org/integration/autoland/rev/0bb33ef812da
Add extension API support for masque proxy r=necko-reviewers,kershaw,robwu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50f1ff7a942c
https://hg.mozilla.org/integration/autoland/rev/8cc81c28ff3e
Revert "Bug 1988988 - Add extension API support for masque proxy r=necko-reviewers,kershaw,robwu" for causing failures at test_ext_proxy_http3.js.

Comment 5

[Atila Butkovits]

Backed out for causing failures at test_ext_proxy_http3.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/8cc81c28ff3e5aecf7ad41912e1bf9ba6121516a

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=UhWPn8RUSl-6QWoST3eCGQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=88d6b94b45209be520e79ec7fca01dffd8e2cf82&searchStr=xpc

Failure log: https://treeherder.mozilla.org/logviewer?job_id=530448707&repo=autoland&task=UhWPn8RUSl-6QWoST3eCGQ.0&lineNumber=3790

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9ae2e1ad1073
https://hg.mozilla.org/integration/autoland/rev/f4cb0102d3b6
Add extension API support for masque proxy r=necko-reviewers,kershaw,robwu

Comment 7

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f4cb0102d3b6

Comment 8

[rbloor]

Documentation updates available in:

• (MDN) Bug 1988988 proxy API support for masque #41563
• c(BCD) Bug 1988988 support for masque in proxy API #28213

Comment 9

[Rob Wu [:robwu]]

The pathTemplate is renamed to masqueTemplate in bug 1998894, which lands in 146. To keep the documentation simple, I recommend listing this feature in the release notes in 146 (not 145). In the "notes" part of BCD, we could add a note "masqueTemplate was named pathTemplate in Firefox 145" or something like that.

Description of masqueTemplate for documentation purposes:

The URI template for the MASQUE proxy, starting from the path component of the URI. This must contain the target_host and target_port template variables as defined in RFC 9298. For example, /.well-known/masque/udp/{target_host}/{target_port}/. Must be set when the proxy type is "masque".