1989054 - [meta] Apply Best Practices for Coroutines aka Coroutines Audit

Status: ASSIGNED

(Firefox for Android :: Accounts and Sync, task)

Description

[Mihai Adrian Carare [:mcarare]]

This meta-ticket tracks the effort to review and refactor our existing Kotlin coroutine usage to align with current best practices.

The goal is to enhance application stability, improve resource management (preventing leaks and/or unnecessary work), ensure correct thread management for UI responsiveness and I/O operations, and increase the overall clarity and testability of our asynchronous code. This involves auditing coroutine scopes, cancellation handling, dispatcher usage, exception handling, and Flow implementations.

What we should look for in the existing codebase (not an exhaustive list):

1. GlobalScope Usage ( we already did that once, we should see if we need to do it again and add safeguards against using it improperly)
2. Coroutine Scope Management & Lifecycle
3. Manual creation of curoutines inside function scopes.
4. Cancellation Handling
5. Dispatcher Usage
6. Exception Handling ( we might swallow CancellationExceptions)
7. Blocking Calls in Coroutines
8. Flow Collection & Lifecycle Awareness
9. Suspending Function Design