Open Bug 1989118 Opened 8 months ago Updated 8 months ago

Share more EnterJit trampoline code

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: iain, Unassigned)

References

(Blocks 1 open bug)

Details

As part of the effort to remove the arguments rectifier, bug 1989107 factors out a shared architecture-independent section of generateEnterJit that handles pushing arguments. There's still a fair bit of unshared code in the architecture-specific implementations for handling OSR and doing the actual call, but the differences between architectures in that code are pretty sparse. We do some arch-specific hackery to push a fake return address, but that's bad for the branch predictor, so we should probably replace it with an actual call, similar to this code in BaselineCodeGen::emitResume.

Blocks: sm-masm
Severity: -- → N/A
You need to log in before you can comment on or make changes to this bug.