1989132 - Remove unnecessary `isTransient` check when removing entries from the active entry list

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task)

Description

[Adam Vandolder [:avandolder]]

The check at https://searchfox.org/firefox-main/rev/302639e599957123f8845cf7655ec10f479f2da2/docshell/base/CanonicalBrowsingContext.cpp#1230 was added when the active entry list consisted of RefPtrs to the various entries, which was causing initial about:blank entries to be kept around for too long and causing crashes when cycle-collecting. Removing transient entries bypassed that issue - but now that the active entry list does not use RefPtrs, these entries are cycle-collected correctly and remove themselves from the list via their destructor, so this check is now unnecessary (and may actually cause entries to be dropped from the list too early).

Comment 1

[Adam Vandolder [:avandolder]]

Attachment: Bug 1989132 - Remove unnecessary transient check when updating the active entry list. r?#dom-core

The check was added when the active entry list consisted of RefPtrs to the
various entries, which caused initial about:blank entries to be kept around for
too long and crashing when being cycle-collected. Removing transient entries
bypassed that issue - but now that the active entry list does not use RefPtrs,
these entries are cycle-collected correctly and remove themselves from the list
via their destructor, so this check is now unnecessary (and may actually cause
entries to be dropped from the list too early).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c83f7c7cd342
https://hg.mozilla.org/integration/autoland/rev/110ca57a03c5
Remove unnecessary transient check when updating the active entry list. r=dom-core,smaug

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/110ca57a03c5