1989215 - Sanitizer: Use unordered sets and a map instead of lists

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Tom Schuster [PTO]]

The Sanitizer API works on lists, but those lists behave more like sets, because they shouldn't really have duplicates. And during the core sanitization work, it's important to be able to quickly check if a specific element is part of the list. Both of these indicate properties really call for a a hash set, but sadly we have to maintain the insertion order, which is observable via the get() method...

Additionally for the elements case (SanitizerElementNamespaceWithAttributes), we have something that is more similar to a map in practice. It maps (namespace, localname) to (attributes, removeAttributes).

Comment 1

[Tom Schuster [PTO]]

We are going to sort the result of get(), so we can go back to using unordered sets.

Comment 2

[Tom Schuster [PTO]]

Attachment: Bug 1989215 - Sanitizer: Use unordered sets and a map instead of lists. r?smaug

Comment 3

[Tom Schuster [PTO]]

Attachment: Bug 1989215 - Sanitizer: Throw on duplicates. r?smaug

Comment 4

[Tom Schuster [PTO]]

Attachment: Bug 1989215 - Sanitizer: Sort the result of the get() method. r?smaug

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d4624d9f111
https://hg.mozilla.org/integration/autoland/rev/0c3f9ae91bc8
Sanitizer: Use unordered sets and a map instead of lists. r=smaug
https://github.com/mozilla-firefox/firefox/commit/9a0627d238cd
https://hg.mozilla.org/integration/autoland/rev/3fc51eb0e8bb
Sanitizer: Throw on duplicates. r=smaug
https://github.com/mozilla-firefox/firefox/commit/8a038d2e7f57
https://hg.mozilla.org/integration/autoland/rev/5f23528ad0d4
Sanitizer: Sort the result of the get() method. r=smaug

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/55497 for changes under testing/web-platform/tests

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0c3f9ae91bc8
https://hg.mozilla.org/mozilla-central/rev/3fc51eb0e8bb
https://hg.mozilla.org/mozilla-central/rev/5f23528ad0d4

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged