1989386 - Ensure ServiceWorkerRegistration can be updated to change worker type between Module vs Classic

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement)

Description

[Harveer Singh]

Ensure ServiceWorkerRegistration can be updated to change worker type between Module vs Classic

Comment 1

[Harveer Singh]

Attachment: Bug 1989386: Correctly update serviceworker type on re-registration.r=edenchuang,asuth

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/137e22f4402e
https://hg.mozilla.org/integration/autoland/rev/3cf4714b3197
Correctly update serviceworker type on re-registration.r=edenchuang,dom-worker-reviewers

Comment 3

[Atila Butkovits]

Backed out for causing failures at browser_dbg-browser-toolbox-workers.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/254ce923c1e5e7c8c431340e57520f419c104d2d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=RKebz0mVQ7--f2vH4XEIUw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2227726e42177c39704b6df370d474183d7503b8

Failure log: https://treeherder.mozilla.org/logviewer?job_id=533577930&repo=autoland&task=RKebz0mVQ7--f2vH4XEIUw.0&lineNumber=5140

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd63d6b6d089
https://hg.mozilla.org/integration/autoland/rev/2e52a6a30a5d
Correctly update serviceworker type on re-registration.r=edenchuang,dom-worker-reviewers

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing dt failures

Backout link

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/62795c77d763
https://hg.mozilla.org/integration/autoland/rev/1315d6394e21
Correctly update serviceworker type on re-registration.r=edenchuang,dom-worker-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1315d6394e21

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for causing the macOS top crash in Bug 1998332.
Backout link: https://hg-edge.mozilla.org/mozilla-central/rev/9a81a01d61b6342b237a6431865eef20ee487c20

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/12f477dc65dc
https://hg.mozilla.org/integration/autoland/rev/1b4d6168b5e8
Correctly update serviceworker type on re-registration.r=edenchuang,dom-worker-reviewers

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1b4d6168b5e8

Comment 11

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.