1989399 - [Settings Search] Add Search button to Settings Toolbar

Status: RESOLVED FIXED

(Firefox for Android :: Settings, task)

Description

[[:harrisono]]

Add Search button to toolbar in the settings page (and subsequent sub-settings pages)

Comment 1

[[:harrisono]]

Attachment: Bug 1989399 - Add new Fragment ext for adding single icon button

Comment 2

[[:harrisono]]

Attachment: Bug 1989399 - Add Search Button to SettingsFragment Toolbar

Depends on D265382

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dff3d698bad2
https://hg.mozilla.org/integration/autoland/rev/899171a18cf0
Add new Fragment ext for adding single icon button r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/36f1e7e74921
https://hg.mozilla.org/integration/autoland/rev/608829b90ff1
Add Search Button to SettingsFragment Toolbar r=android-reviewers,Roger

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/899171a18cf0
https://hg.mozilla.org/mozilla-central/rev/608829b90ff1

Comment 5

[[:harrisono]]

Attachment: Bug 1989399 - Fix action space error in `Fragment.showToolbarWithIconButton`

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/82ed6edd84ed
https://hg.mozilla.org/integration/autoland/rev/ca261930fd9e
Fix action space error in `Fragment.showToolbarWithIconButton` r=android-reviewers,Roger

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ca261930fd9e

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)