Closed
Bug 1989429
Opened 6 months ago
Closed 6 months ago
When unloading all tabs, don't show Firefox View if it has been hidden
Categories
(Firefox :: Tabbed Browser, defect, P4)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
145 Branch
People
(Reporter: gstoll, Assigned: gstoll)
References
Details
Attachments
(1 file)
As pointed out in bug 1946432, we should not show Firefox View if the button is hidden (for example, because it's in a private window).
|
Assignee | |
Updated•6 months ago
|
Assignee: nobody → gstoll
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 months ago
|
||
We previously did this if the Firefox View button had been removed from
the toolbar. This change also checks for the case when the Firefox View
button is present but hidden, as in what happens in private browsing mode.
Pushed by gstoll@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/8faf724c2f61
https://hg.mozilla.org/integration/autoland/rev/a922758a98f0
after unloading all tabs, don't select Firefox View if the button is hidden r=tabbrowser-reviewers,sthompson,dao
|
||
Comment 3•6 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox145:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
|
||
Updated•5 months ago
|
QA Whiteboard: [qa-triage-done-c146/b145] [qa-ver-needed-c146/b145]
Flags: qe-verify+
|
||
Updated•5 months ago
|
QA Contact: oardelean
|
|
||
Comment 4•5 months ago
|
||
Issue is reproducible on a 2025-09-18 Firefox Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 146.0a1 and Firefox 145.0b4 on Windows 10, Ubuntu 22, macOS 15.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c146/b145] [qa-ver-needed-c146/b145] → [qa-triage-done-c146/b145] [qa-ver-done-c146/b145]
status-firefox146:
--- → verified
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•