Closed Bug 1989449 Opened 8 months ago Closed 7 months ago

[wpt-sync] Sync PR 54936 - [WebXr] Use Strongly type IDs across mojom

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox145 fixed)

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 54936 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54936
Details from upstream follow.

Alexander Cooper <alcooper@chromium.org> wrote:

[WebXr] Use Strongly type IDs across mojom

Updates the mojom interfaces for planes, anchors, and hit tests to use
the strongly typed ID types. Given that these are uint64_t's, this is
accomplished by introducing small wrapper types to mojom that are then
typemapped to the base::IdType alias. Note that in order to use these
Ids as their underlying values in blink, some hash_traits were needed
to be created. The nature of updating these types to be sent across
mojom required removing uint64_t's where they were used for these
types across both sides of the pipe, but the end result is cleaner
and clearer about which types are used where. The Ids are now
essentially opaque handles outside of their respective classes that
directly create them.

Bug: 394772465
Change-Id: I6401d01084c2fa51111a03786debbc6f90ff918c
Reviewed-on: https://chromium-review.googlesource.com/6962793
WPT-Export-Revision: 92b4e6798d9a5566a5642a55c83425ef49882a06

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
You need to log in before you can comment on or make changes to this bug.