1989537 - [wpt-sync] Sync PR 54946 - Use Keyboard Lock instead of Web Locks to disable BFCache in tests

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 54946 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/54946
Details from upstream follow.

Anna Sato <[e-mail]> wrote:

Use Keyboard Lock instead of Web Locks to disable BFCache in tests

This CL switches some BFCache-disabling test helpers to use
navigator.keyboard.lock() instead of navigator.locks.request().

With upcoming changes, Web Locks will no longer be a simple
BFCache-blocking feature. The new logic will evict a cached page holding
a lock only when another page requests it.

Bug: 443003971
Change-Id: Id9fb00d7b8fef391cb8b5280f22920b59c1d8e59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6968130
Owners-Override: Fergal Daly \<[e-mail]>
Reviewed-by: Fergal Daly \<[e-mail]>
Reviewed-by: Mingyu Lei \<[e-mail]>
Commit-Queue: Anna Sato \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1517810}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=abc5dab4b4cd54edb749dff65b74bab775e8a309

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 4

Chrome

OK : 2
PASS : 2

Safari

TIMEOUT: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-traverse-navigation-cross-origin-redirect-no-bfcache.https.sub.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • pageswap on traverse navigation from script: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-traverse-navigation-no-bfcache.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: TIMEOUT)
  • pageswap on traverse navigation from script: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c5eb7e868e8b
https://hg.mozilla.org/integration/autoland/rev/017eca1b346e
[wpt PR 54946] - Use Keyboard Lock instead of Web Locks to disable BFCache in tests, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/017eca1b346e