198995 - nsScriptLoader::OnStreamComplete reports an erroneous assertion

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Bradley]

When a channel provides a charset
(http://lxr.mozilla.org/seamonkey/source/content/base/src/nsScriptLoader.cpp#770),
and GetPreferred doesn't return one and returns an error
(http://lxr.mozilla.org/seamonkey/source/content/base/src/nsScriptLoader.cpp#777),
the assertion is fired. I don't think this should happen, but the paths of this
function are rather complex.

I'm using a trunk build on WinXP from 3/23

Comment 1

[David Bradley]

This problem might be that the code at line 773 is using characterSet instead of
a temporary like the code at 789 is doing

Comment 2

[David Bradley]

Attachment: A possible fix

I'm not sure this is the right thing, but it mimics the code below and clears
up the assertion problem

Comment 3

[Johnny Stenback (:jst)]

David, could you provide a link to a page that shows this problem? I'd like to
step through this code in such a case to make sure we get this right.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 118319 [details] [diff] [review]
A possible fix

r=jst

Comment 5

[Johnny Stenback (:jst)]

Fix checked in.