1989976 - Tab group doorhanger not attached to anything (with vertical tabs on the right)

Status: UNCONFIRMED

(Firefox :: Messaging System, defect, P1)

Description

[:Vincent]

Attachment: screenshot.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:143.0) Gecko/20100101 Firefox/143.0

Steps to reproduce:

I opened Nightly. It showed a doorhanger, saying "Try tab groups for less clutter, more focus". I have vertical tabs enabled and shown in expanded state on the right-hand side.

Actual results:

The doorhanger overlapped the sidebar, and the attachment chevron pointed to an arbitrary place on the content.

Expected results:

I'm not sure what it should be attached to, but presumably it should be something. (Or maybe it should not be shown if the element is not visible.)

Comment 1

[Emily McMinn :emcminn]

Hi Vincent!
Could you possibly tell me a little more about the state of your tab strip when you saw the callout? It's a little hard to see in your screenshot.

This callout has several anchors, and I'm trying to figure out if one of them isn't working correctly, or if we need to add another to cover an edge case we hadn't thought of. In order of priority, the callout anchors:

1 - to the active tab, as long as it isn't a pinned tab,
2 - to the last unpinned tab, if the active tab is pinned,
3 - to the " + New tab" button, if there are no unpinned tabs or the tabs are in overflow/hidden
4 - to the (vertical) center of the tab strip, if none of the other anchors work.

From your screenshot, it looks to me like the callout is pointing at some empty space, which is possible with the last anchor, but weird for it to be at the top of the screen like that. It also shouldn't be happening if you had other open tabs. Did you have pinned tabs, and were there other open tabs visible? Was the New Tab button visible?

Thanks for helping debug this!

Comment 2

[:Vincent]

Hi Emily - ha, the doorhanger obscures it all. I usually have just a single tab open, and no pinned tabs, so I think that was the case here too. (But of course, the doorhanger is gone now.) So I think option 1 should apply, which means it's positioned at the correct height, but should be located to the left-hand side of the sidebar, and the anchor should've been on the right-hand side of the doorhanger. I'll attach another screenshot without the doorhanger.

Comment 3

[:Vincent]

Attachment: sidebar-without-doorhanger.png

Comment 4

[Emily McMinn :emcminn]

Ah okay that helps a ton! So the issue is that the callout didn't correctly flip for a right-hand sidebar, but it did otherwise pick the correct anchor. I'll work on reproducing it. Thanks!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:hanna_a, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Ina Popescu, Desktop QA]

I tried to reproduce this on Nightly 146.0.1 and older builds with vertical tabs on the right, but the “Try tab groups” doorhanger did not appear. It seems this doorhanger only shows temporarily, so I am unable to reproduce the issue.

Comment 7

[foreal]

it did otherwise pick the correct anchor. I'll work on reproducing it. Thanks!...........