1990092 - [A11y] The Cancel and Save buttons don't have a keyboard navigation visual focus

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• The Cancel and Save buttons don't have a keyboard navigation visual focus.

Found in

• Nightly v145.0a1

Affected versions

• Nightly v145.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Load a PDF (https://ontheline.trincoll.edu/images/bookdown/sample-local-pdf.pdf)
2. Use the keyboard to navigate to the "Text" button from the PDF.js menu bar.
3. Select it, choose a location and insert some text.
4. Press ESC to finish inserting text.
5. Press TAB twice to reach the Edit comment button and press ENTER.
6. Insert some random text and tap TAB.

Expected result

• The focus moves to the Cancel button and a visual focus is shown.

Actual result

• The focus is moved to the Cancel button, but there is not visual focus shown.

Regression range

• Not a regression.

Comment 1

[Anna Yeddi [:ayeddi] (Leave starting on July 3, 2026)]

Missing focus indicator is an access-S2 issue that makes this part of the UI inaccessible for users of assistive technologies, especially those relying on keyboard alone, because it is not clear what is, if anything, is currently focused and what could happen, if this invisible element is activated. This also makes the navigation with keyboard unpredictable.

Comment 2

[Calixte Denizet (:calixte)]

Attachment: [mozilla/pdf.js][Editor] Fix the focus outline for the comment dialog buttons (#20281)

Comment 3

[Daniel Bodea [:danibodea]]

I can confirm this fix in the lastest Nightly v145.0a1 on Windows 10, MacOS 11 and Ubuntu 24 ARM. The Cancel, Add/Update buttons now displaya a keboard navigation visual focus.