Closed Bug 1990309 Opened 1 year ago Closed 1 year ago

Promote ESLint rule mozilla/no-browser-refs-in-toolkit to an error, except for existing files where it fails

Categories

(Developer Infrastructure :: Lint and Formatting, task, P2)

task

Tracking

(firefox145 fixed)

RESOLVED FIXED
145 Branch
Tracking Status
firefox145 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 external file)

The current roll-out for the ESLint rule mozilla/no-browser-refs-in-toolkit is for the rule to be enabled as a warning. We've seen cases where we're not sure if code review bot is picking these warnings up (being investigated elsewhere).

On reflection, I think that we can enable it as a failure for any file where it currently isn't raising an issue, and keep it as warning for the current failures. This will help to prevent it being added in new files without being handled/missed.

Pushed by mbanner@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/78372bb63fe0 https://hg.mozilla.org/integration/autoland/rev/8f51ffe8f420 Change ESLint rule mozilla/no-browser-refs-in-toolkit to be an error, keeping as a warning for existing issues. r=frontend-codestyle-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: