1990448 - -moz-subtree-hidden-only-visually doesn't work on out of flows.

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

We plan to use something very similar to implement position-visibility. Also the split view implementation might need it for <tabpanels> (I took a look at making the content area use abspos rather than grid, and hit this).

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1990448 - Do content-visibility checks on the container. r=#layout

No behavior change, but this saves some per-child work and conceptually
is the right thing to do. HidesContent() is non-trivial.

Add an assertion to make sure we don't enter BuildDisplayListForChild
at all if content is hidden.

I audited all the callers, and the ones I didn't touch can't have
content-visibility (things like the viewport / pages / etc).

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1990448 - Check ShouldSkipFrame on the out of flow. r=#layout

Placeholders don't have the right style. This fixes
-moz-subtree-hidden-only-visually on out of flows, which is currently
not used but might be needed for the front-end.

Unfortunately this is restricted currently to the parent process, which
means that my attempt at a reftest didn't work... I could write a
browser test by absolutely positioning a tab panel or something but that
seems a bit clunky...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/67ec7b59e055
https://hg.mozilla.org/integration/autoland/rev/73c934745551
Do content-visibility checks on the container. r=layout-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/163d61e02055
https://hg.mozilla.org/integration/autoland/rev/29be892785c8
Check ShouldSkipFrame on the out of flow. r=layout-reviewers,tnikkel
https://github.com/mozilla-firefox/firefox/commit/f7e038bbdc56
https://hg.mozilla.org/integration/autoland/rev/0c1ba181e55d
apply code formatting via Lando

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/73c934745551
https://hg.mozilla.org/mozilla-central/rev/29be892785c8
https://hg.mozilla.org/mozilla-central/rev/0c1ba181e55d