1990454 - Add PDF comments SUMO page to the 'Learn more' link from null comments message

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Raluca Popovici, Desktop QA]

Attachment: Screenshot 2025-09-24 at 14.53.09.png

Found in:
Nightly 145.0a1(2025-09-23)

Affected versions:
Nightly 145.0a1(2025-09-23)

Tested platforms:

Affected platforms: macOS 13.2.1, Windows 11, Ubuntu 24
Unaffected platforms:

Steps to reproduce:

1. Load a PDF without any comments.
2. Click on the 'Comments' icon from the PDF toolbar.
3. Click on the 'Learn more' link.

Expected result:
A valid link that redirects to the PDF comments SUMO page.

Actual result:
Link is not valid. SUMO page not found.

Regression range:
This is not a regression; it is a bug related to the new implementation of the PDF comments.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Fix the URL for the 'Learn more' link in the comment sidebar (bug 1990454) (#20308)

Comment 2

[Calixte Denizet (:calixte)]

I need to write an other patch in order to fix the locale part of the URL, so I'm reopening this bug.

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1990454 - Replace %LOCALE% by the locale value in the 'Learn more' URL in the comment sidebar r=#pdfjs-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c951aec5ca66
https://hg.mozilla.org/integration/autoland/rev/8b3229386885
Replace %LOCALE% by the locale value in the 'Learn more' URL in the comment sidebar r=pdfjs-reviewers,marco

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8b3229386885

Comment 6

[Raluca Popovici, Desktop QA]

Shouldn't this page also include the comment section?

Comment 7

[Calixte Denizet (:calixte)]

It should but it isn't ready for the moment (see https://bugzilla.mozilla.org/show_bug.cgi?id=1990454).