1990491 - The user should be able to deselect comments from the Comments Sidebar

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, enhancement, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• The user can open and close the comment boxes by clicking the in-content Comment buttons/icons. When the user is reading comments from the Comments Sidebar, he can open them by clicking a specific comment from the sidebar, but he can't close the comment box by chicking the sidebar comment again.
• Alternatively, he can close a specific comment box by opening another comment box OR by clickgint the specific comment's in-content icon OR by tapping the ESC key.

Found in

• Nightly v145.0a1

Affected versions

• Nightly v145.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Load a PDF sample.
   https://pdfobject.com/pdf/sample.pdf
2. Leave a few random comments in the doc.
3. Open the Comment Sidebar (from the PDF.js manubar).
4. Click a specific comment from the Comment Sidebar to open the ion-content comment box.
5. Click the specific comment from the Comment Sidebar again, to close the in-content comment box.

Expected result

• The in-content comment box is closed.

Actual result

• The in-content comment box remains opened.

Regression range

• not a regression.

Additional notes

• Alternatively, the user can close the in-content comment box by clicking it's comment icon, pressing ESC key or opening a different in-content comment box.

Comment 1

[Daniel Bodea [:danibodea]]

Attachment: cannot deselect comments from sidebar.gif

Comment 2

[Calixte Denizet (:calixte)]

Ryan wdyt ?

Comment 3

[Ryan Casey]

Im not opposed to it, but will it interfere with how alternative navigation users can interact with it? Im referring to this spec:
https://www.figma.com/design/zIsOSgvNPjMN90tUJfzn5B/PDF.js--Comments?node-id=534-143734&t=Hf5w6BHm5Ui4OK5v-1

Comment 4

[Daniel Bodea [:danibodea]]

I would seem this improvement has been implemented. If the case, can you change it's status to reflect it? Thanks!

Comment 5

[Calixte Denizet (:calixte)]

Attachment: [mozilla/pdf.js][Editor] Add the possibility to unselect a comment from the sidebar (#20322)

Comment 6

[Daniel Bodea [:danibodea]]

I can confirm this fix in Beta v145.b7 and Nightly v146.0a1 in Windows 10, MacOS 13 and Ubuntu 24. The user can now deselect comments from the Comments Sidebar.