1990504 - Fix Preferences and Settings types being implicitly any

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Kennedy [:mark]]

Attachment: PreferencesSettingsConfig_type.png

Some types used in Settings and Preference files are implicitly any and failing to map to the correct types due to some file shuffling that happened recently on main branch. For example, PreferencesSettingsConfig in toolkit/content/preferences/Setting.mjs file is incorrect (see attachment).

Comment 1

[Mark Kennedy [:mark]]

Attachment: Bug 1990504 - Expose Setting and Preferences types that are implicitly any r=#reusable-components-reviewers-rotation

Comment 2

[Mark Kennedy [:mark]]

Attachment: Bug 1990504 - Fix and import Setting and Preference types to avoid them being implicitly any r=#reusable-components-reviewers-rotation

Comment 3

[Mark Kennedy [:mark]]

Attachment: Bug 1990504 - Exclude custom lit.all.mjs file from type check r=#reusable-components-reviewers-rotation

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3c8ee1c288fa
https://hg.mozilla.org/integration/autoland/rev/062cd5cfb4eb
Expose Setting and Preferences types that are implicitly any r=hjones
https://github.com/mozilla-firefox/firefox/commit/abe7692c971a
https://hg.mozilla.org/integration/autoland/rev/259dcb4eedd5
Fix and import Setting and Preference types to avoid them being implicitly any r=hjones
https://github.com/mozilla-firefox/firefox/commit/07c9e545921c
https://hg.mozilla.org/integration/autoland/rev/f2e705a9388c
Exclude custom lit.all.mjs file from type check r=hjones

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60e7487cbe70
https://hg.mozilla.org/integration/autoland/rev/1eb2d9276b00
Revert "Bug 1990504 - Exclude custom lit.all.mjs file from type check r=hjones" for causing multiple bc failures.

Comment 6

[Iulian Moraru]

Revert for causing multiple bc failures.

• Push with failures

• Failure log

• Failure log

• Failure log

• Backout link

Comment 7

[Mark Kennedy [:mark]]

Ah, I know why this is happening. Due to types being explicitly enforced on some files... Will fix...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3387151957a7
https://hg.mozilla.org/integration/autoland/rev/2a4f5f9873e8
Expose Setting and Preferences types that are implicitly any r=hjones
https://github.com/mozilla-firefox/firefox/commit/160fa8b87d6d
https://hg.mozilla.org/integration/autoland/rev/29adfa3ce7cf
Fix and import Setting and Preference types to avoid them being implicitly any r=hjones
https://github.com/mozilla-firefox/firefox/commit/76b71541407e
https://hg.mozilla.org/integration/autoland/rev/d513f870f829
Exclude custom lit.all.mjs file from type check r=hjones

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/2a4f5f9873e8
https://hg.mozilla.org/mozilla-central/rev/29adfa3ce7cf
https://hg.mozilla.org/mozilla-central/rev/d513f870f829