1990529 - storage.sync returns sanitized "An unexpected error occurred" error without logging the original error

Status: RESOLVED FIXED

(WebExtensions :: Storage, task, P3)

Description

[Rob Wu [:robwu]]

While looking into bug 1989840, I noticed that on older Firefoxes a generic error was reported without the actual error being dumped to the console. This makes debugging difficult, and to see the actual error I had to put a breakpoint at https://searchfox.org/firefox-main/rev/6cd61ea1ff39887da8f4dc1080a96c01f0c70ef8/toolkit/components/extensions/ExtensionStorageSync.sys.mjs#78

With the fix at bug 1990313 (so Firefox no longer crashes), I expect the same issue (generic error being reported without more diagnostics) to happen.

Let's add some more logging.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1990529 - Log unsanitized error on internal storage.sync

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/13aa8ab1d77f
https://hg.mozilla.org/integration/autoland/rev/46deed4f9bb8
Log unsanitized error on internal storage.sync r=rpl

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/46deed4f9bb8