1990793 - Live policies proper application

Status: RESOLVED FIXED

(Enterprise Products :: Firefox, task)

Description

[:gerard-majax]

When live policies has been prototypes, a new observer was added EnterprisePolicies:Activate that will blindly run all policies callbacks. This may be a problem if we run them at the early startup phase before the expected observer event has been sent.

STR was:

{
    "policies": {
        "BlockAboutConfig": true,
        "DisableFirefoxScreenshots": true,
        "ExtensionSettings": {
            "{a3331e55-214f-49f8-a9d8-0ab78558885f}": {
              "installation_mode": "force_installed",
              "install_url": "https://addons.mozilla.org/firefox/downloads/file/4289501/aurora_ray_lights-1.0.xpi",
              "updates_disabled": true
            }
        }
    }
}

to serve an XPI to install. This would fail because this policy depends on onBeforeUIStartup which is run only when final-ui-startup has been received

Proper solution would be to just schedule those calls for later, when it's too early. But for later calls to apply the policy it should be fine to run directly

Comment 1

[:gerard-majax]

Attachment: GitHub Pull Request

Comment 2

[:gerard-majax]

This was fixed by merging this PR

Comment 3

[:gerard-majax]

https://github.com/mozilla/enterprise-firefox/commit/2620227eb3204354cf08043ccd3d7c6a33fcfbb1