1990820 - [A11y][keyboard navigation] After adding, editing, cancelling or deleting a comment, the keyboard focus is lost to other elements

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Note

• After the user adds a comment, edits or deletes it, he will notice that the focus is lost somewhere above the elements he has been working on.

Found in

• Nightly v145.0a1

Affected versions

• Nightly v145.0a1

Tested platforms

• Affected platforms: Windows10+NVDA
• Unaffected platforms:

Steps to reproduce

1. Enable the Screen Reader
2. Launch the browser
3. Load a PDF sample (https://ontheline.trincoll.edu/images/bookdown/sample-local-pdf.pdf)
4. Add any of the following elements to the PDF: Signature, Highlight, Text, Drawing, Image.
5. Using keyboard navigation (TAB), navigate to the created/inserted element.
6. Press TAB to navigate to the "Edit comment" button under the element and press ENTER.
7. Insert any message.
8. Press TAB to navigate to the "Save" button.
9. Press ENTER.

Expected result

• The comment is saved and the focus is moved to the created/inserted element.

Actual result

• The comment is saved and the focus is moved above the PDF.js menubar.

Regression range

• Not a regression.

Additional notes

• This issue also occurs in the following situations:

1. Adding comments
2. Editing a comment and Cancelling.
3. Editing a comment and Saving.
4. Removing a comment.

• This issue occurs in all OS types (Windows 10, MacOS 11, MacOS 13, Ubuntu 22...(
• This issue occurs with and withought the use of a Screen Reader specific to each OS.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Move the focus to the comment button once editing is done (bug 1990820) (#20304)

Comment 2

[Eitan Isaacson [:eeejay]]

Very annoying, but does not make the feature completely inaccessible.

Comment 3

[Daniel Bodea [:danibodea]]

I can verify this fix in Nightly v145.0a1 in Windows 10, MacOS 11 and Ubuntu 24 ARM.

• Whether the user uses a Screen Reader or not, after he adds a comment, the keyboard navigation focus is moved to the newly creaded "Show comment" button/icon.
• If he edits or cancels an edit, then the focus moves to the same "Show comment" button/icon.
• When removing a comment, the keyboard navigation visual focus is moved to the element that the comment was attached to (or so it seems).

This being said, there is an edge case if the element with the comment is the last one in the PDF document, when moving away it will be slightly confusing as the next focused elements are not the respective element's controls (eg. change color, edit comment, remove highligh), but the first other element in the PDF. This edgecase was logged as bug 1992832.