1990884 - Rename and move `AnchorPosReferencedAnchors` from `nsStyleStructs.h`

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

That header is crowded, AnchorPosReferencedAnchors et al. should really live in AnchorPositioningUtils.h.
It should also be renamed since we'll be keeping track of scroll-related data.

Separating it out of bug 1968745 to land this first since it can have repercussions to others. This will take 1 point of work from bug 1968745.

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1990884: Rename AnchorPosReferencedAnchors to AnchorPosReferenceData. r=#anchor-positioning-reviewers

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1990884: Move AnchorPosReferenceData from nsStyleStructs.h to AnchorPositioningUtils.h. r=#anchor-positioning-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/299d6ecd10c5
https://hg.mozilla.org/integration/autoland/rev/03d0776c5576
Rename AnchorPosReferencedAnchors to AnchorPosReferenceData. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/850a073fceb1
https://hg.mozilla.org/integration/autoland/rev/ff8d942f94ec
Move AnchorPosReferenceData from nsStyleStructs.h to AnchorPositioningUtils.h. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d73470d01e6c
https://hg.mozilla.org/integration/autoland/rev/852c14399af2
Revert "Bug 1990884: Move AnchorPosReferenceData from nsStyleStructs.h to AnchorPositioningUtils.h. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio" for causing build bustages in nsAbsoluteContainingBlock.h.

Comment 5

[Serban Stanca [:SerbanS]]

Reverted this because it was causing build bustages in nsAbsoluteContainingBlock.h.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/generic/nsAbsoluteContainingBlock.h(122,7): error: unknown type name 'AnchorPosReferenceData'; did you mean 'mozilla::AnchorPosReferenceData'?

Comment 6

[David Shin[:dshin]]

Woops, missed a spot after separating the patch - fixed, and trying again

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37dcaf1be4ae
https://hg.mozilla.org/integration/autoland/rev/0d13e317d111
Rename AnchorPosReferencedAnchors to AnchorPosReferenceData. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/c43b58897e79
https://hg.mozilla.org/integration/autoland/rev/d5b0b668d63b
Move AnchorPosReferenceData from nsStyleStructs.h to AnchorPositioningUtils.h. r=layout-anchor-positioning-reviewers,firefox-style-system-reviewers,layout-reviewers,emilio

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0d13e317d111
https://hg.mozilla.org/mozilla-central/rev/d5b0b668d63b