1990972 - Allow IP Protection exclusions to be modified from the settings page

Status: RESOLVED INVALID

(Firefox :: IP Protection, task, P1)

Description

[kpatenio]

Follow up to Bug 1990013. We want the ability to modify site exclusions from the settings page once the UI is implemented.

Things to add:

• See registered site exclusions (if any) in the settings UI
• Add new domains through the UI
• Remove existing domains from the UI

Loading the exclusions

• We can easily access the set of exceptions via IPPExceptionsManager. With this, we can potentially pass off the domains to the custom component for the settings UI.

Possible approach to add / remove domains
Perhaps we can take a similar to approach to dohExceptions.js:

• After we load the exceptions by reading our exclusions / inclusions prefs and populate the sets, we can run logic that "builds" the list for us in the dialog. dohExceptions calls a method that does this.
• There's two options: either we expand IPPExceptionsManager to do the building for us, or we attach another JS file specific to the dialog's behaviour; our script will use IPPExceptionsManager to check if the sets are populated and then iterate through them.

Figma

• https://www.figma.com/design/l75lLbgf95PuVqNafzdvel/VPN---Firefox-Integration--Pilot?node-id=14147-264404&m=dev

Comment 1

[kpatenio]

Attachment: settings UI exclusions.png

Comment 2

[kpatenio]

Update: this is also a follow up to Bug 1993334, which handles the actual rendering of the exceptions dialogs.

Comment 3

[kpatenio]

Requirements indicated in this bug are outdated, for we now rely on the Permissions system to add site exceptions. Plus, we are transitioning to the MVP version of the feature, which will have significant UI changes. Closing this bug since it's no longer relevant.