Closed
Bug 19910
Opened 26 years ago
Closed 25 years ago
One Bugzilla eats other Bugzilla's cookies on same server
Categories
(Bugzilla :: Creating/Changing Bugs, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: bryce-mozilla, Assigned: myk)
Details
Attachments
(6 files)
|
7.70 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.66 KB,
patch
|
Details | Diff | Splinter Review | |
|
8.17 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.87 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
|
7.78 KB,
patch
|
Details | Diff | Splinter Review | |
|
7.52 KB,
patch
|
myk
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
I use two Bugzillas at different sites. Each time I switch, the new bugzilla
asks me for my login again, forgetting that it has a perfectly good cookie with
that information from last time.
This is annoying. Almost annoying enough for me to fix it myself :-).
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → WORKSFORME
Comment 1•26 years ago
|
||
I thought cookies weren't supposed to have this kind of problem. And, in fact,
it doesn't for me. Marking WORKSFORME.
Comment 3•25 years ago
|
||
The real problem here is that bugzilla uses a path of '/' for its cookie and
uses a statis name for the cookie. It should really use a cookie name that is
dependend upon the name of the database and a path that is based upon its
location in the web tree. Otherwise, if you have several bugzilla installations
on a single server, the cookies will stomp upon one another.
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
Comment 4•25 years ago
|
||
OK, but I'm not sure we support two bugzillas. I'll leave this open as we
probably should.
Comment 5•25 years ago
|
||
The problem that was origingally reported here I will verify as WORKSFORME,
because I use Bugzillas on 3 different systems frequently, and I never have to
re-login on any of them unless my IP changes. I can move back and forth at will.
However, this bug has morphed into allowing two bugzillas on the same server,
which probably wouldn't be too bad an idea. I do this a lot for development
purposes... one bugzilla with the production database, and the other with a test
DB I can play with for development and testing. Changing summary to describe
this better.
Summary: Bugzilla eats other bugzilla's cookies → One Bugzilla eats other Bugzilla's cookies on same server
Updated•25 years ago
|
Target Milestone: --- → Future
Comment 6•25 years ago
|
||
This is an RFE, but moving to 2.16 because we need this to work for landfill.
Severity: normal → enhancement
Priority: P3 → P1
Target Milestone: Future → Bugzilla 2.16
Comment 7•25 years ago
|
||
moving
Assignee: tara → myk
Component: Bugzilla → Creating/Changing Bugs
Product: Webtools → Bugzilla
Version: other → 2.10
Comment 8•25 years ago
|
||
I have the same issue here and I propose a solution.
Have a param called cookiepath that is placed in to each Set-Cookie statement.
For example in the data params file:
$::param{cookiepath} = '/bugzilla';
and then have for each Set-Cookie statement:
print "Set-Cookie: Bugzilla_login=$enteredlogin ; path=" . Param('cookiepath') .
"; expires=Sun, 30-Jun-2029 00:00:00 GMT\n";
Comment 9•25 years ago
|
||
| Assignee | ||
Comment 10•25 years ago
|
||
Comment on attachment 53160 [details] [diff] [review]
Patch to define cookie path as a param value
Patch looks good except for the tab characters...
>Index: buglist.cgi
>+ my $cookiepath = Param("cookiepath");
>Index: colchange.cgi
>+ my $cookiepath = Param("cookiepath");
>Index: defparams.pl
>+ "Directory path under your document root that holds your Bugzilla installation. Make sure to begin with a /.",
>+ "t",
>+ "/");
Comment 11•25 years ago
|
||
Darn tabs. I will regenerate a new patch and attach :)
Comment 12•25 years ago
|
||
Comment 13•25 years ago
|
||
Comment 14•25 years ago
|
||
| Assignee | ||
Comment 15•25 years ago
|
||
Comment on attachment 53354 [details] [diff] [review]
Cookie path patch v4 (better spacing)
looks good to me. r=myk
Attachment #53354 -
Flags: review+
Comment 16•25 years ago
|
||
Comment 17•25 years ago
|
||
| Assignee | ||
Comment 18•25 years ago
|
||
Comment on attachment 53362 [details] [diff] [review]
Cookie path patch (got all of the Bugzilla_password instances this time)
looks good.
Attachment #53362 -
Flags: review+
Comment 19•25 years ago
|
||
Comment on attachment 53362 [details] [diff] [review]
Cookie path patch (got all of the Bugzilla_password instances this time)
r= justdave
Attachment #53362 -
Flags: review+
Comment 20•25 years ago
|
||
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v <-- CGI.pl
new revision: 1.113; previous revision: 1.112
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <-- buglist.cgi
new revision: 1.148; previous revision: 1.147
/cvsroot/mozilla/webtools/bugzilla/colchange.cgi,v <-- colchange.cgi
new revision: 1.18; previous revision: 1.17
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v <-- createaccount.cgi
new revision: 1.14; previous revision: 1.13
/cvsroot/mozilla/webtools/bugzilla/defparams.pl,v <-- defparams.pl
new revision: 1.60; previous revision: 1.59
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v <-- post_bug.cgi
new revision: 1.35; previous revision: 1.34
/cvsroot/mozilla/webtools/bugzilla/query.cgi,v <-- query.cgi
new revision: 1.91; previous revision: 1.90
/cvsroot/mozilla/webtools/bugzilla/relogin.cgi,v <-- relogin.cgi
new revision: 1.11; previous revision: 1.10
Status: NEW → RESOLVED
Closed: 26 years ago → 25 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•