1991050 - Use OS auth when OS auth is enabled and PrP is already unlocked

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Simon Friedberger [:simonf]]

Currently we prompt people for their primary password when we are trying to reauthenticate the user. Even if OS auth is available.

It would be a much better experience if this would only use actual OS authentication, e.g. a fingerprint scan when the PrP is already unlocked.

If the PrP is locked we need to prompt for it anyway so in that case we should skip the OS authentication.

Comment 1

[Simon Friedberger [:simonf]]

Attachment: Bug 1991050: Use OS auth even if PrP is set. r=mtigley

Comment 2

[Simon Friedberger [:simonf]]

The remaining problem here is that not all platforms support OS authentication. For those cases we want a way to prompt for the PrP which does not lock the NSS token. That doesn't need to be solved here, though. We can just fix this only on platforms which do support reauthentication.

Comment 3

[Simon Friedberger [:simonf]]

We briefly discussed adding a pref for this but concluded that, if people selected that they want OS auth, they should be getting OS auth. Even if they have a Primary Password set, because that should be used for encryption not for user authentication because authentication with OS auth would be less friction.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6aae77a65edd
https://hg.mozilla.org/integration/autoland/rev/468b21876801
Use OS auth even if PrP is set. r=mtigley,credential-management-reviewers,joschmidt

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3228096d3b20
https://hg.mozilla.org/integration/autoland/rev/81ef65445652
Revert "Bug 1991050: Use OS auth even if PrP is set. r=mtigley,credential-management-reviewers,joschmidt" for causing bc failures on browser_primaryPassword.js

Comment 6

[Cristina Horotan [:chorotan]]

Backed out for causing bc failures on browser_primaryPassword.js

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37a518137e75
https://hg.mozilla.org/integration/autoland/rev/270481e886af
Use OS auth even if PrP is set. r=mtigley,credential-management-reviewers,joschmidt

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6e94d932c94b
https://hg.mozilla.org/integration/autoland/rev/5cabf311c60e
Revert "Bug 1991050: Use OS auth even if PrP is set. r=mtigley,credential-management-reviewers,joschmidt" for causing bc failures @browser_sandbox_test.js.

Comment 9

[Goloman Adrian[:agoloman]]

Backed out for causing bc failures @browser_sandbox_test.js.

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e96c67090eac
https://hg.mozilla.org/integration/autoland/rev/ee7ea6953db4
Use OS auth even if PrP is set. r=mtigley,credential-management-reviewers,joschmidt

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee7ea6953db4