1991365 - C++20 designated initializer list requires CodecOverrides to be an aggregate type

Status: RESOLVED FIXED

(Core :: WebRTC, task, P3)

Description

[Chris Peterson [:cpeterson]]

C++20 designated initializer list requires CodecOverrides to be an aggregate type.

In C++17, designated initializers like {.field = value} are not part of the standard, but some compilers (e.g. GCC, Clang) allowed them as an extension.

In C++20, designated initializers were standardized, but they only work for aggregate types (structs with no user-declared constructors, no base classes, no private/protected non-static data members).

/builds/worker/checkouts/gecko/media/webrtc/signaling/gtest/jsep_track_unittest.cpp:444:28: error: initialization of non-aggregate type 'CodecOverrides' with a designated initializer list
|   offerCodecs = MakeCodecs({.addDtmfCodec = true});
|                            ^~~~~~~~~~~~~~~~~~~~~~

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1991365 - C++20 designated initializer list requires CodecOverrides to be an aggregate type. r?ng,#webrtc-reviewers

In C++17, designated initializers like {.field = value} are not part of the standard, but some compilers (e.g. GCC, Clang) allowed them as an extension.

In C++20, designated initializers were standardized, but they only work for aggregate types (structs with no user-declared constructors, no base classes, no private/protected non-static data members).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/367dc23e30e6
https://hg.mozilla.org/integration/autoland/rev/2bc9e018bb8e
C++20 designated initializer list requires CodecOverrides to be an aggregate type. r=webrtc-reviewers,pehrsons

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2bc9e018bb8e