1991500 - Remove the enableMenuRedesign setting and old menu code

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

When we are ready, we will want to enableMenuRedesign setting, its associated nimbus flags and the old menu code.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 1: Remove "Enable Menu Redesign" from Secret Settings

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 2: Remove building the `HomeMenu` in `HomeMenuView`

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 1: Remove "Enable Menu Redesign" from Secret Settings

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 2: Remove building the `HomeMenu` in `HomeMenuView`

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 3: Removes `onItemTapped` handling in `HomeMenuView`

• Removes the handler of all the HomeMenu.Items
• Removes the telemetry events that are no longer collected

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 4: Remove unneeded `dismissMenu` function from `HomeMenuView`

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 5: Remove `HomeMenu`

• Removes unused HomeMenu
• Removes unused icons, strings and telemetry events from removing HomeMenu

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 6: Remove `CustomTabToolbarMenu` from `CustomTabsIntegration`

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 1: Remove "Enable Menu Redesign" from Secret Settings

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 2: Remove building the `HomeMenu` in `HomeMenuView`

Comment 11

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 3: Removes `onItemTapped` handling in `HomeMenuView`

• Removes the handler of all the HomeMenu.Items
• Removes the telemetry events that are no longer collected

Comment 12

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 4: Remove unneeded `dismissMenu` function from `HomeMenuView`

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 5: Remove `HomeMenu`

• Removes unused HomeMenu
• Removes unused icons, strings and telemetry events from removing HomeMenu

Comment 14

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 6: Remove `CustomTabToolbarMenu` from `CustomTabsIntegration`

Comment 15

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 7: Remove setting the menu builder in `ToolbarIntegration`

Comment 16

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 8: Remove unused `ToolbarMenuBuilder`

Comment 17

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 9: Remove unused `CustomTabToolbarMenu`

Comment 18

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 10: Remove `DefaultToolbarMenu`

Comment 19

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1991500 - Part 11: Remove `enableMenuRedesign` settings

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6bd033005022
https://hg.mozilla.org/integration/autoland/rev/5821d7fdd6ed
Part 1: Remove "Enable Menu Redesign" from Secret Settings r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/0f7450f6c92a
https://hg.mozilla.org/integration/autoland/rev/8eebd1ac4bf6
Part 2: Remove building the `HomeMenu` in `HomeMenuView` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/388444dedf40
https://hg.mozilla.org/integration/autoland/rev/1cf7abd3697d
Part 3: Removes `onItemTapped` handling in `HomeMenuView` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/e7f65db3efe0
https://hg.mozilla.org/integration/autoland/rev/41b7e3abedf1
Part 4: Remove unneeded `dismissMenu` function from `HomeMenuView` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/a0abf520ebe6
https://hg.mozilla.org/integration/autoland/rev/16e601d4bf14
Part 5: Remove `HomeMenu` r=android-reviewers,android-l10n-reviewers,petru,flod
https://github.com/mozilla-firefox/firefox/commit/3fe0be3eb65f
https://hg.mozilla.org/integration/autoland/rev/9a0dfc92b4d5
Part 6: Remove `CustomTabToolbarMenu` from `CustomTabsIntegration` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/2a85db124648
https://hg.mozilla.org/integration/autoland/rev/f821357cc946
Part 7: Remove setting the menu builder in `ToolbarIntegration` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/bbc20d466374
https://hg.mozilla.org/integration/autoland/rev/ea0507a25958
Part 8: Remove unused `ToolbarMenuBuilder` r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/bf9301a285ae
https://hg.mozilla.org/integration/autoland/rev/fc71a282bd2d
Part 9: Remove unused `CustomTabToolbarMenu` r=android-reviewers,android-l10n-reviewers,petru,flod
https://github.com/mozilla-firefox/firefox/commit/664604c3596c
https://hg.mozilla.org/integration/autoland/rev/763b21d65072
Part 10: Remove `DefaultToolbarMenu` r=android-reviewers,android-l10n-reviewers,petru,flod
https://github.com/mozilla-firefox/firefox/commit/1d0fb958b9f6
https://hg.mozilla.org/integration/autoland/rev/b2260480a08f
Part 11: Remove `enableMenuRedesign` settings r=android-reviewers,petru

Comment 21

[amarc]

https://hg.mozilla.org/mozilla-central/rev/5821d7fdd6ed
https://hg.mozilla.org/mozilla-central/rev/8eebd1ac4bf6
https://hg.mozilla.org/mozilla-central/rev/1cf7abd3697d
https://hg.mozilla.org/mozilla-central/rev/41b7e3abedf1
https://hg.mozilla.org/mozilla-central/rev/16e601d4bf14
https://hg.mozilla.org/mozilla-central/rev/9a0dfc92b4d5
https://hg.mozilla.org/mozilla-central/rev/f821357cc946
https://hg.mozilla.org/mozilla-central/rev/ea0507a25958
https://hg.mozilla.org/mozilla-central/rev/fc71a282bd2d
https://hg.mozilla.org/mozilla-central/rev/763b21d65072
https://hg.mozilla.org/mozilla-central/rev/b2260480a08f

Comment 22

[Serban Stanca [:SerbanS]]

Reverted this because it was causing build bustages in HTMLMediaElement.cpp.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/mediaelement/HTMLMediaElement.cpp:X:14: error: format specifies type 'int' but the argument has type 'StreamCaptureBehavior' [-Werror,-Wformat]