1992007 - Update FollowSectionButtonHighlight component to show on first section (instead of second) section

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Prefs

Set the following prefs to true:

• browser.newtabpage.activity-stream.asrouter.devtoolsEnabled
• browser.newtabpage.activity-stream.discoverystream.sections.enabled
• browser.newtabpage.activity-stream.discoverystream.personalization.enabled

_Note: You should not be following any topics _

Test scenarios:

1. Open new tab
2. Expected: The sections layout should be visible for Recommended Storieis (including the "Follow" button next to each topic)
3. Navigate to about:asrouter and scroll down until you find TEST_NEWTAB_MESSAGE
4. Replace the contents with the following JSON block:

{
  "weight": 100,
  "id": "TEST_NEWTAB_MESSAGE",
  "template": "newtab_message",
  "content": {
    "messageType": "FollowSectionButtonHighlight",
    "darkModeDismiss": true
  },
  "trigger": {
    "id": "newtabMessageCheck"
  },
  "groups": [],
  "targeting": "providerCohorts.panel_local_testing == \"SHOW_TEST\"",
  "provider": "panel_local_testing"
}

1. Click "Modify" (to submit this message data)
2. Refresh new tab
3. Expected: The FollowSectionButtonHighlight message should be visible, pointing to the FIRST "Follow" topic button
4. Actual: The FollowSectionButtonHighlight message is visible and pointing to the SECOND "Follow" topic button

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1992007 - Update FollowSectionButtonHighlight display logic r?#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a7974ab2f8a7
https://hg.mozilla.org/integration/autoland/rev/ac97f8abb684
Update FollowSectionButtonHighlight display logic r=home-newtab-reviewers,nbarrett

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ac97f8abb684