1992028 - Add 'details-from' attribute to clarify details relationship origin.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Eitan Isaacson [:eeejay]]

Chrome exposes a details-from attribute when an accessible has a details relation. This would be straightforward to implement for the automatic details relations we create, but should we?

Comment 1

[James Teh [:Jamie] (away returning 12 Jan)]

The idea here is to enable AT to filter out details relationships if they decide they don't want to report them or the like. However, I'd argue that if AT start filtering out automatic details relations of any type, that suggests we possibly shouldn't be exposing them in the first place.

NVDA doesn't use details-from at this stage. Interestingly, it does have an advanced setting to toggle reporting of aria-description via description-from.

My thinking at this stage is that this isn't a wontfix, but I don't think we should invest in it unless a client actually wants to start using it.

Comment 2

[Jonathan Watt [:jwatt]]

Do we need this to ship?

Comment 3

[Eitan Isaacson [:eeejay]]

Yes. I'll have a patch ready today.

Comment 4

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1992028 - Implement details-from attribute. r?Jamie

This allows ATs to distinguish the source of details relations.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7224b9290783
https://hg.mozilla.org/integration/autoland/rev/677f00d1d060
Implement details-from attribute. r=Jamie

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f25db7cef8ac
https://hg.mozilla.org/integration/autoland/rev/3d83a788cebd
Revert "Bug 1992028 - Implement details-from attribute. r=Jamie" for causing mda and dt failures.

Comment 7

[agoloman]

Backed out for causing mda and dt failures.

• Backout link
• Push with failures
• Failure Log mda failures
• Failure Log dt failures
• Failure Log reftest failures

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/809deced26bd
https://hg.mozilla.org/integration/autoland/rev/e7d7c86f8748
Implement details-from attribute. r=Jamie

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e7d7c86f8748