1992031 - Context menu separator is missing on "Flexible Space" item context menu during customize toolbar mode

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Kyler Riggs [:kylr]]

Attachment: "Flexible Space" context menu during "Customize Toolbar" mode.

Steps to reproduce:

1. Go to "Customize Toolbar."
2. Add a "Flexible Space" somewhere if there isn't one already on your toolbar.
3. Right click the "Flexible Space."

Actual results:

The context menu that appears is missing a separator between "Remove from Toolbar" and "Menu Bar"

Expected results:

There should be a separator between "Remove from Toolbar" and "Menu Bar." Other context menus with these options have a separator between them.

Comment 1

[Kyler Riggs [:kylr]]

Found this bug while working on another bug. I can also work on the fix for this one.

Comment 2

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Hello, thank you for the bug report!
Managed to reproduce this issue on:

• Firefox Nightly 145.0a1;
• Firefox 144.0b8;

Tested on:

• Windows 10;
• Ubuntu 22;
• macOS 15;

Setting as NEW.

Comment 3

[Kyler Riggs [:kylr]]

Attachment: Bug 1992031 - Show menu separator on 'Flexible Space' items when in customize mode r=#firefox-desktop-core-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e2c68930ed32
https://hg.mozilla.org/integration/autoland/rev/737cb1ccb59f
Show menu separator on 'Flexible Space' items when in customize mode r=firefox-desktop-core-reviewers ,Gijs

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/737cb1ccb59f

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kylr, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox145 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-10-01 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 147.0a1 and Firefox 146.02 on Windows 10, Ubuntu 22, macOS 15.