1992036 - Force-reshowing the toolbox in fullscreen mode when a webauthn prompt is up is broken

Status: VERIFIED FIXED

(Core :: DOM: Web Authentication, defect)

Description

[:Gijs (he/him)]

See bug 1880918 comment 8:

(In reply to Henry Wilkes (they/them) [:henry-x])

@Gijs should this line also be changed to

Services.obs.notifyObservers(gNavToolbox, "fullscreen-nav-toolbox", "hidden");

Otherwise, I think this line will throw an error since aSubject will be null. I've not tested it in practice myself.

This analysis looks correct to me. I must have lost the change in a rebase or something, I remember at some point doing the replacements and later being confused about how many there were, but somehow managed to convince myself that there wasn't one missing in the end - clearly I was wrong. :-\

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1880918

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1992036 - fix broken notification for hiding navtoolbox, r?Mossop

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7162eb3ae15
https://hg.mozilla.org/integration/autoland/rev/74397e099b2b
fix broken notification for hiding navtoolbox, r=mossop

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/74397e099b2b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Gijs, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox144 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Potentially the toolbox doesn't get reshown if there is a webauthn prompt "fighting" with fullscreen. It's not entirely clear to me how urgent/bad this is, but equally the patch is very straightforward.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: re-verify https://bugzilla.mozilla.org/show_bug.cgi?id=1823720 on at least Windows and macOS/Linux
• Risk associated with taking this patch: low
• Explanation of risk level: One line patch
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1992036 - fix broken notification for hiding navtoolbox, r?Mossop

Original Revision: https://phabricator.services.mozilla.com/D267402

Comment 8

[Simona Badau, Desktop QA]

Attachment: Prompt on Ubuntu

I can confirm that the full-screen toast is displayed after dismissing the WebAuthn prompt from Bug 1823720 on the latest Nightly 145.0a1 on macOS 15 and Windows 11.

On Ubuntu 25.04 I cannot enter full screen: when clicking the test page I get a “Touch your security key to continue” prompt (please see attached video) and full screen is automatically exited.

@Gijs, is there any way to bypass this prompt so I can verify the appearance of the fullscreen toolbox on Ubuntu 25.04?

Comment 9

[:Gijs (he/him)]

(In reply to Simona Badau, Desktop QA from comment #8)

Created attachment 9518945 [details]
Prompt on Ubuntu

I can confirm that the full-screen toast is displayed after dismissing the WebAuthn prompt from Bug 1823720 on the latest Nightly 145.0a1 on macOS 15 and Windows 11.

On Ubuntu 25.04 I cannot enter full screen: when clicking the test page I get a “Touch your security key to continue” prompt (please see attached video) and full screen is automatically exited.

@Gijs, is there any way to bypass this prompt so I can verify the appearance of the fullscreen toolbox on Ubuntu 25.04?

I think if it's working on Windows and macOS that is probably sufficient right now? I think the race condition probably just plays out slightly differently on your Ubuntu machine vs. macOS, and that is OK.

Comment 10

[Simona Badau, Desktop QA]

(In reply to :Gijs (he/him) from comment #9)

I think if it's working on Windows and macOS that is probably sufficient right now? I think the race condition probably just plays out slightly differently on your Ubuntu machine vs. macOS, and that is OK.

Thank you, Gijs!
Based on this and Comment 8, marking the tracking flag for 145 as verified.

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7ba47784cc5d
https://hg.mozilla.org/releases/mozilla-release/rev/5bae1d8bf18a

Comment 12

[Simona Badau, Desktop QA]

Verified as fixed using Firefox 142 (Build ID: 20251009125714) on Windows 11 and macOS 15 - full-screen toast is displayed after dismissing the WebAuthn prompt from Bug 1823720.