1992079 - The Nimbus flag for Custom Review prompt should NOT include enabling/disabling the legacy Play Store review feature

Status: VERIFIED FIXED

(Firefox for Android :: Experimentation and Telemetry, defect, P1)

Description

[twhite]

The Nimbus flag for Custom Review prompt should only enable/disable for the new Custom Review prompt feature, it should NOT include enabling/disabling the legacy Play Store review feature.

The legacy ShowPlayStorePrompt should still be displayed if the custom-review-prompt is disabled. The legacy review prompt should be reinstated as it was previously - see bug 1976872 for details.

Comment 1

[Marcin Koziński]

Attachment: Bug 1992079 - Keep legacy review prompt behavior if Nimbus flag for custom review prompt disabled

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox143 (release), tracked for firefox144 (beta) and tracked for firefox145 (nightly). However, the bug still has low severity.

:towhite, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 3

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: when custom review prompt nimbus flag disabled, no review prompt is shown at all, instead of falling back to legacy prompt behaviour
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: fix isolated to single class, covered with tests, verified manually
• String changes made/needed: -
• Is Android affected?: no

Comment 4

[Marcin Koziński]

Attachment: Bug 1992079 - Keep legacy review prompt behavior if Nimbus flag for custom review prompt disabled

Original Revision: https://phabricator.services.mozilla.com/D267197

Comment 5

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: when custom review prompt nimbus flag disabled, no review prompt is shown at all, instead of falling back to legacy prompt behaviour
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: fix isolated to a single class, covered by tests and verified manually
• String changes made/needed: -
• Is Android affected?: no

Comment 6

[Marcin Koziński]

Attachment: Bug 1992079 - Keep legacy review prompt behavior if Nimbus flag for custom review prompt disabled

Original Revision: https://phabricator.services.mozilla.com/D267197

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ecbfaf8159ae
https://hg.mozilla.org/integration/autoland/rev/06290099cbd5
Keep legacy review prompt behavior if Nimbus flag for custom review prompt disabled r=android-reviewers,twhite

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/21b6e2d8e22e
https://hg.mozilla.org/releases/mozilla-beta/rev/9d0839708f76

Comment 9

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0822a986821c
https://hg.mozilla.org/releases/mozilla-release/rev/5b0624e91c22

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/06290099cbd5

Comment 11

[Mira Lobontiu (Android QA)]

Attachment: 20251006_174900.jpg

Verified as fixed on the latest Firefox for Android Nightly 145.0a1 from 10/6 using a Pixel 6 (Android 16).
I followed these steps to test:

1. Start from a fresh install.
2. Make sure the Nimbus flag is disabled from the "Enable Custom Review Prompt" from Nimbus Experiments.
3. Set as default browser.
4. Force stop and reopen the app 5-6 times.

I'll verify also on Beta 144.0b10 and on 143.0.4 dot release, and get back with the results.

Comment 12

[Mira Lobontiu (Android QA)]

Attachment: Screenshot_20251007-102541.png

Verified as fixed also on 144.0 Firefox for Android.
Tested with the same steps above, on a Motorola Moto G30 (Android 12).