1992201 - Add new copy profile section to settings

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Niklas Baumgardner [:niklas]]

Attachment: image.png

See figma: https://www.figma.com/design/cCmVBQQfWKd3I9rgaUqOLo/Profiles-MVP-fast-follows?node-id=9751-24122&m=dev

See attached screenshots.

Add ability to copy a profile from the Profiles section in the settings page.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: WIP: - Bug 1992201 - Update profiles settings the old way. Next, move to new-settings style.

• Make the button on the main page just say settings.
• get the manage profiles button working in the subpanel
• added copy profile section
• dynamically populating the list. now to make the copy button work.
• get profile copy fully working. Next, switch to new-settings style.
• set a max-width on the select element so long profiles don't break the
  subpane layout

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: WIP: Bug 1992201 - converting to new settings

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1992201 - Add settings sub-pane for profiles, including copy feature r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,niklas

Note we hide the copy profile section until you have either created a
profile (app menu > profiles > new profile) or inited the database (by
clicking the 'manage profiles' button just above. Then you have to
refresh the page.

Still TODO:

• style to match the figma
• add tests
• dynamically update the visibility based on the user creating profiles
  or initing the database by hitting 'manage profiles'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/97e64235a90f
https://hg.mozilla.org/integration/autoland/rev/a500a8e470ee
Add settings sub-pane for profiles, including copy feature r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,niklas

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0c5162be2060
https://hg.mozilla.org/integration/autoland/rev/6089de002578
Revert "Bug 1992201 - Add settings sub-pane for profiles, including copy feature r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,niklas" for causing multiple bc leaks.

Comment 6

[agoloman]

Backed out for causing multiple bc leaks.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/119527231c32
https://hg.mozilla.org/integration/autoland/rev/2f1db8afe69c
Add settings sub-pane for profiles, including copy feature r=profiles-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,niklas

Comment 8

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/2f1db8afe69c

Comment 9

[Raluca Popovici, Desktop QA]

Verified as fixed on MacOS 13.2.1, Ubuntu 24.10 and Windows 11 using Nightly treeherder build. The Copy Profile section remains hidden until the user has created a profile from App Menu > Profiles > New Profile or from the ‘Manage Profiles’ (Profiles Settings). After that, the Profiles Settings section must be refreshed so you can select the profile you created and copy it.
@Jared, will this patch be uplifted to Beta 146 today?