1992231 - Display Unsupported Detected Language Info Message in about:translations

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P2)

Description

[Erik Nordin [:nordzilla]]

Description

The about:translations design (internal only) has never displayed a proper info message if the detected language is not yet supported for translation.

Now that we are redesigning the UI, we should ensure that it has a proper UI info message if the detected language is not supported.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992231 - Remove AnyEventDetail from about:translations tests r=sfoster!

This commit removes the catch-all AnyEventDetail option from
existing about:translations tests. We can, and should, be fully
deterministic and specific about any event details that we assert.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992231 - Clean up about:translations focus handling r=sfoster!

about:translations has requirements that the focus outline should be
around the entire section, which may contain a textarea and a copy
button, for example. This commit attempts to move more of that handling
into the CSS, rather than the JavaScript code.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992231 - Improve about:translations section-height tests r=sfoster!

This commit makes our section-height assertions more rigorous,
rather than only asserting that the heights increased or decreased,
we now make assertions against the actual pixels.

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992231 - about:translations translation error message r=sfoster!

This commit adds a new error message that shows within the
target section if a translation request fails.

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992231 - Misc. Translations Tests Improvments r=sfoster!

This commit contains various miscellaneous fixes within
the Translations tests that should hopefully improve
intermittent test failures and better guard against
race conditions within the test code.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6996f18283b0
https://hg.mozilla.org/integration/autoland/rev/5e760b228b90
Remove AnyEventDetail from about:translations tests r=sfoster
https://github.com/mozilla-firefox/firefox/commit/15c699379444
https://hg.mozilla.org/integration/autoland/rev/a022b4ffe47e
Misc. Translations Tests Improvments r=sfoster
https://github.com/mozilla-firefox/firefox/commit/801958e02f76
https://hg.mozilla.org/integration/autoland/rev/05d27dab867a
Clean up about:translations focus handling r=desktop-theme-reviewers,sfoster
https://github.com/mozilla-firefox/firefox/commit/c1b4ec5d9585
https://hg.mozilla.org/integration/autoland/rev/949c105d9430
Improve about:translations section-height tests r=sfoster
https://github.com/mozilla-firefox/firefox/commit/e41f879cfa76
https://hg.mozilla.org/integration/autoland/rev/b3003125df16
about:translations translation error message r=fluent-reviewers,desktop-theme-reviewers,bolsson,sfoster

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b23f64fdfb98
https://hg.mozilla.org/integration/autoland/rev/2d97cc387177
Revert "Bug 1992231 - about:translations translation error message r=fluent-reviewers,desktop-theme-reviewers,bolsson,sfoster" for causing bc failures @ browser_MLSuggest_integration.js

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_MLSuggest_integration.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2d97cc387177f9e37822209df483fce769193384

Push with failures

Failure log -> browser/components/urlbar/tests/browser/browser_MLSuggest_integration.js

Comment 9

[Erik Nordin [:nordzilla]]

This is part of a single backout that spanned multiple bugs.

In the patch stack, I increased the timeout when waiting for a mocked RemoteSettings model to download within our Translations tests, hoping that it might also help to reduce intermittent Translations test failures.

There are a few ml related tests that share our Remote Settings mocks. This test case happens to wait for the full duration of the timeout as part of the success path of the test case.

I've reverted the timeout change, and everything should hopefully be fine now.

I would one day like to either fully separate this code, or unify it in a way that ml doesn't rely on Translations under the hood, so that its more clear where the downstream consumers are.

Comment 10

[Erik Nordin [:nordzilla]]

Restoring the original timeout seems to have fixed the issue:

• https://hg.mozilla.org/try/rev/f90e8c8356a1b6f859b28cf430158700cbf43901
• https://treeherder.mozilla.org/jobs?repo=try&revision=c4b57d3456613bf4d05a01e04ce95a3679a2c8db

---

Attempting re-landing.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50a84500d43b
https://hg.mozilla.org/integration/autoland/rev/5afc0a529e6f
Remove AnyEventDetail from about:translations tests r=sfoster
https://github.com/mozilla-firefox/firefox/commit/e372d02303f0
https://hg.mozilla.org/integration/autoland/rev/02615c33a5e5
Misc. Translations Tests Improvments r=sfoster
https://github.com/mozilla-firefox/firefox/commit/cff09ff9e910
https://hg.mozilla.org/integration/autoland/rev/403ec39812da
Clean up about:translations focus handling r=desktop-theme-reviewers,sfoster
https://github.com/mozilla-firefox/firefox/commit/a4ed76ce89b7
https://hg.mozilla.org/integration/autoland/rev/1a781f928214
Improve about:translations section-height tests r=sfoster
https://github.com/mozilla-firefox/firefox/commit/9f6db817de4b
https://hg.mozilla.org/integration/autoland/rev/53b09c82a87c
about:translations translation error message r=fluent-reviewers,desktop-theme-reviewers,bolsson,sfoster

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5afc0a529e6f
https://hg.mozilla.org/mozilla-central/rev/02615c33a5e5
https://hg.mozilla.org/mozilla-central/rev/403ec39812da
https://hg.mozilla.org/mozilla-central/rev/1a781f928214
https://hg.mozilla.org/mozilla-central/rev/53b09c82a87c