1992233 - Imlement about:translations Clear Button

Status: RESOLVED FIXED

(Firefox :: Translations, enhancement, P2)

Description

[Erik Nordin [:nordzilla]]

Description

Our new about:translations designs (internal only) include a clear button at the top-right of the source text area, which will clear the source text when clicked.

We need to implement this button.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992233 - Part 1/3: Add Source Section Clear Button r=#translations-reviewers!

This commit adds the actions column and clear button to the source section
of the about:translations page. This introduces the new UI element sonly,
ensuring that the pre-existing lofic is consistent, especially resizing.

At this point, the button is always shown and has no functionality.
Subsequent commits will add the show/hide/click logic as well as tests.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992233 - Part 2/3: Implement Clear Butotn Visibility r=#translations-reviewers!

This commit introduces the logic for when the source-section clear button
should be visible or hidden on the about:translations page.

At this point, the button has no functionality when clicked.
This will be added in the next commit.

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1992233 - Part 3/3: Implement Clear Button Functionality r=#translations-reviewers!

This commit implements the logic for clicking the source-section clear
button on the about:translations page. Invoking the clear button will
clear the source text, resulting in the button now being hidden, and
the source-text section having focus.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/75259352201f
https://hg.mozilla.org/integration/autoland/rev/49ff5f55f586
Part 1/3: Add Source Section Clear Button r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
https://github.com/mozilla-firefox/firefox/commit/bd005d4ae09f
https://hg.mozilla.org/integration/autoland/rev/d9f440f83337
Part 2/3: Implement Clear Butotn Visibility r=translations-reviewers,gregtatum
https://github.com/mozilla-firefox/firefox/commit/dabbf9a4cd16
https://hg.mozilla.org/integration/autoland/rev/87d4cc80dacf
Part 3/3: Implement Clear Button Functionality r=translations-reviewers,gregtatum

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/49ff5f55f586
https://hg.mozilla.org/mozilla-central/rev/d9f440f83337
https://hg.mozilla.org/mozilla-central/rev/87d4cc80dacf