1992376 - retrigger gets into an infinite loop if a push has more than 1000 action tasks

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect, P3)

Description

[Julien Cristau [:jcristau]]

The request to taskcluster in https://searchfox.org/firefox-main/rev/2c8e9bccfd6ce951ceda8d46ab619f461b7fd0bc/third_party/python/taskcluster_taskgraph/taskgraph/util/taskcluster.py#264 is buggy:

• it uses the POST version of listTasks instead of GET
• it passes continuationToken in the POST body instead of the GET query string
• the index service ignores that value, so we keep getting the same 1000 tasks back over and over

A minimal fix looks like the below, although there's bigger changes to this code in taskgraph 16.

diff --git a/third_party/python/taskcluster_taskgraph/taskgraph/util/taskcluster.py b/third_party/python/taskcluster_taskgraph/taskgraph/util/taskcluster.py
--- a/third_party/python/taskcluster_taskgraph/taskgraph/util/taskcluster.py
+++ b/third_party/python/taskcluster_taskgraph/taskgraph/util/taskcluster.py
@@ -253,25 +253,25 @@ def get_artifact_from_index(index_path, 
 
 
 def list_tasks(index_path, use_proxy=False):
     """
     Returns a list of task_ids where each task_id is indexed under a path
     in the index. Results are sorted by expiration date from oldest to newest.
     """
     results = []
-    data = {}
+    params = {}
     while True:
         response = _do_request(
-            get_index_url(index_path, use_proxy, multiple=True), json=data
+            get_index_url(index_path, use_proxy, multiple=True), params=params, method="get"
         )
         response = response.json()
         results += response["tasks"]
         if response.get("continuationToken"):
-            data = {"continuationToken": response.get("continuationToken")}
+            params = {"continuationToken": response.get("continuationToken")}
         else:
             break
 
     # We can sort on expires because in the general case
     # all of these tasks should be created with the same expires time so they end up in
     # order from earliest to latest action. If more correctness is needed, consider
     # fetching each task and sorting on the created date.
     results.sort(key=lambda t: parse_time(t["expires"]))

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:bhearsum, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Julien Cristau [:jcristau]]

This was fixed as part of bug 1990567.