1992524 - 28,700 instances of "NS_ENSURE_TRUE(mPresShell) failed" emitted from layout/generic/nsFrameSelection.cpp during windows11-64-24h2 debug testing

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Andrew McCreight [:mccr8]]

28745 WARNING: NS_ENSURE_TRUE(mPresShell) failed: file layout/generic/nsFrameSelection.cpp:1736

This is the 3rd most common warning on Windows, 4th most common on MacOS, and 7th most common on Linux.

It looks like mPresShell is null in nsFrameSelection::RepaintSelection(). Is this a useful warning? It appears to be concentrated in a few tests.

This warning shows up in 184 test suites. A few of the most prevalent:

  1237 - test-windows11-64-24h2/debug-web-platform-tests-16 wpt16
   638 - test-windows11-64-24h2/debug-web-platform-tests-wdspec-headless-2 Wd2
   632 - test-windows11-64-24h2/debug-web-platform-tests-wdspec-2 Wd2
   605 - test-windows11-64-24h2/debug-mochitest-browser-chrome-spi-nw-12 bc12
   601 - test-windows11-64-24h2/debug-mochitest-browser-chrome-12 bc12
   573 - test-windows11-64-24h2/debug-web-platform-tests-7 wpt7
   506 - test-windows11-64-24h2/debug-web-platform-tests-wdspec-headless-4 Wd4
   501 - test-windows11-64-24h2/debug-web-platform-tests-wdspec-4 Wd4
   497 - test-windows11-64-24h2/debug-mochitest-devtools-chrome-4 dt4
   471 - test-windows11-64-24h2/debug-marionette-swr 1

It shows up in 5324 tests. A few of the most prevalent:

  1718 -        Shutdown
  1030 -        /html/semantics/forms/textfieldselection/selection.html
   714 -        widget/tests/browser/browser_test_ime_state_in_contenteditable_on_focus_move_in_remote_content.js
   714 -        widget/tests/browser/browser_test_ime_state_on_focus_move_in_remote_content.js
   504 -        /html/semantics/popovers/popover-invoking-attribute.html
   483 -        browser/extensions/formautofill/test/browser/address/browser_phonenumber.js
   357 -        widget/tests/browser/browser_test_ime_state_in_designMode_on_focus_move_in_remote_content.js
   255 -        widget/tests/test_ime_state_on_focus_move_in_parent.html
   234 -        /webdriver/tests/classic/new_session/unhandled_prompt_behavior.py
   168 -        layout/base/tests/browser_animatedImageLeak.js

Comment 1

[Andrew McCreight [:mccr8]]

Looks like this warning was added in bug 368760.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1992524 - Remove warning from nsFrameSelection::RepaintSelection().

This warning is in the top 10 on all 3 desktop platforms and doesn't look very useful.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1f5a94293590
https://hg.mozilla.org/integration/autoland/rev/d5368552989b
Remove warning from nsFrameSelection::RepaintSelection(). r=smaug

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d5368552989b