1992536 - Crash in [@ mozilla::net::CookieServiceParent::SetCookies]

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect)

Description

[BugBot [:suhaib / :marco]]

Crash report: https://crash-stats.mozilla.org/report/index/aafa2193-4d06-4cfb-8d44-ef6bb0250919

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(error == nsICookieValidation::eOK)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::net::CookieServiceParent::SetCookies  netwerk/cookie/CookieServiceParent.cpp:345
1  xul.dll  mozilla::dom::WindowGlobalParent::RecvSetCookies  dom/ipc/WindowGlobalParent.cpp:1807
2  xul.dll  mozilla::dom::PWindowGlobalParent::OnMessageReceived  ipc/ipdl/PWindowGlobalParent.cpp:2131
3  xul.dll  mozilla::dom::PContentParent::OnMessageReceived  ipc/ipdl/PContentParent.cpp:6523
4  xul.dll  mozilla::ipc::MessageChannel::DispatchAsyncMessage  ipc/glue/MessageChannel.cpp:1797
4  xul.dll  mozilla::ipc::MessageChannel::DispatchMessage  ipc/glue/MessageChannel.cpp:1723
4  xul.dll  mozilla::ipc::MessageChannel::RunMessage  ipc/glue/MessageChannel.cpp:1512
5  xul.dll  mozilla::ipc::MessageChannel::MessageTask::Run  ipc/glue/MessageChannel.cpp:1614
5  xul.dll  mozilla::RunnableTask::Run  xpcom/threads/TaskController.cpp:705
5  xul.dll  mozilla::TaskController::RunTask  xpcom/threads/TaskController.cpp:196

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2025-09-19
• Process type: Parent
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - 2 out of 5 crashes happened on null or near null memory address

By analyzing the backtrace, the regression may have been introduced by a patch [1] to fix Bug 1982261.

[1] https://hg.mozilla.org/mozilla-central/rev?node=05d9c3f01472

:baku, since you are the author of the potential regressor, could you please take a look?

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Also, what's the impact of this bug on Release builds where diagnostic asserts aren't enabled?

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1992536 - Use cookie creation time instead or PR_Now() to validate the expiration time, r?valentin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37f622b02d48
https://hg.mozilla.org/integration/autoland/rev/fe6e63a2f914
Use cookie creation time instead or PR_Now() to validate the expiration time, r=valentin,cookie-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fe6e63a2f914

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f78d4178527a
https://hg.mozilla.org/releases/mozilla-beta/rev/2396618e7aca

Comment 7

[Pascal Chevrel (relman team) -> :pascalc]

Backed out from beta at the developer's request.