1992770 - [A11y][Keyboard Navigation] Unexpected keyboard navigation order when tabbing through the inserted elements and attached comments

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Daniel Bodea [:danibodea]]

Attachment: unnexpected order of focus with keyboard navigation.gif

Note

• After inserting any elements to a PDF document and attaching comments to them, tapping the TAB key will first focus the inserted elements and only afterwards will it focus on the comments.

Found in

• Nightly v145.0a1

Affected versions

• Nightly v145.0a1

Tested platforms

• Affected platforms: all
• Unaffected platforms: none

Steps to reproduce

1. Load a PDF document.
2. Insert any elements and attach comments.
3. Close the dialogs (Comments Sidebar, Signature, Highlights, Text insertion, Drawing, Image insertion)
4. Click in the top of the document.
5. Press TAB multiple times to navigate through the inserted elements and their comments.

Expected result

• Keyboard navigation goes through the inserted elements AND their comments in top-down order.

Actual result

• Firstly, keyboard navigation goes through the inserted elements, when it reaches the last one it will move to the last one's comment icon, then move upwards to the previous comment icon in the page untill it reaches the first comment icon.

Regression range

• This is not a regression as this feature is still in the implementation phase. A worse behavior was observed before this.

Additional notes

• This issue also occurs if various types of inserted elements with comments are created before testing.
• This issue will no longer reproduce after saving the PDF document locally.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [Editor] Make sure that annotation positions in the DOM respect the visual order (bug 1992770) (#20344)

Comment 2

[Daniel Bodea [:danibodea]]

This fix has been verified in Windows 10, MacOS 14.7.1 M1 and Ubuntu 24 ARM. Keyboard navigation works in top-down order, as expected.